Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-2861

TARMK Cold Standby better binary decoding

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.14, 1.2.3, 1.3.0, 1.4
    • segmentmk
    • None

    Description

      The ColdStandby relies on an inefficient decoding mechanism which increases exponentially the times needed to transfer a binary (ex. a 300mb file can go over 10min). The issue is around the use of a ReplayingDecoder (the ReplyDecoder class) which will eagerly create byte arrays of the original length for each received fragment of the transferred file.
      So following the 300mb file example, for each inbound slice of hundreds of kbs, a new 300mb arrays is allocated, only to be thrown away by the ReplayingDecoder once it figures out the entire stream is not available yet.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            stillalex Alex Deparvu
            stillalex Alex Deparvu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment