[OAK-2814] Refactor the optimize logic regarding path include and exclude to avoid duplication

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.14, 1.2.3, 1.3.0, 1.4
• Component/s: core
• Labels: technical_debt
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 27/Apr/15 09:46
• Updated: 02/Mar/16 11:31
• Resolved: 06/May/15 06:27

Description

ObservationManagerImpl has a optimize method which process the list of includes and excludes and removes redundant clauses. That logic is now also being used in index filtering (OAK-2599) and is getting duplicated.

Going forward we need to refactor this logic so that both places can use it without copying. Possibly making it part of PathUtils

mduerig Also suggested to further optimize

Also PathFilter#optimise could be further optimised by removing entries that subsume each other (e.g. including /a/b, /a is the same as including (/a.

Issue Links

• relates to: OAK-2599 Allow excluding certain paths from getting indexed for particular index