[OAK-2754] Use non unique PathCursor in LucenePropertyIndex

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.14, 1.3.0, 1.4
• Component/s: lucene
• Labels: resilience
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 11/Apr/15 06:33
• Updated: 07/Apr/16 04:18
• Resolved: 29/May/15 14:36

Description

LucenePropertyIndex currently uses unique PathCursor [1] due to which the cursor would maintain an in memory set of visited path. This might grow big if result size is big and cursor is traversed completely.

As with current impl the path would not be duplicated we can avoid using unique cursor

[1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java#L1153-1154

Issue Links

• breaks: OAK-4009 Search done via Lucene index might return duplicate results
• is related to: OAK-4167 Collect and backport lucene based suggestion improvements done in 1.4 into 1.2 branch