[OAK-2259] SegmentBlob equals check should verify compaction in both directions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.9, 1.1.3
• Component/s: segmentmk
• Labels: compaction gc
• Assignee: Alex Deparvu
• Reporter: Alex Deparvu
• Created: 07/Nov/14 14:45
• Updated: 15/Jan/15 14:48
• Resolved: 09/Nov/14 11:20

Description

It looks like the SegmentNodeState checks compaction in one direction [0], while the SegmentBlob checks in the other direction. This will not break anything as the fallback is to use byte comparison, but it will be terribly slow.
I'm proposing to verify both directions in the #equals check, to make sure we don't miss out.

[0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeState.java#L401
[1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentBlob.java#L198

Issue Links

• is depended upon by: OAK-2192 Concurrent commit during compaction results in mixed segments