[OAK-2192] Concurrent commit during compaction results in mixed segments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.9, 1.1.4
• Component/s: core, segmentmk
• Labels: compaction gc
• Epic Link: SegmentMK revision GC
• Assignee: Michael Dürig
• Reporter: Michael Dürig
• Created: 14/Oct/14 19:10
• Updated: 14/Oct/15 12:54
• Resolved: 16/Dec/14 19:04

Description

Changes that are committed during a segment store compaction run will be compacted on top of the already compacted changes. However the compactor uses the wrong before state in this case. Instead of compacting against the compacted before state it uses the un-compacted before state. The resulting state will thus contain references to un-compacted state, making those not eligible for later clean up.

Issue Links

• depends upon: OAK-2140 Segment Compactor will not compact binaries > 16k
• depends upon: OAK-2254 Observation events accessibility check should respect session refresh settings
• depends upon: OAK-2255 PermissionStoreImpl refresh root on flush
• depends upon: OAK-2256 MemoryNodeBuilder NPE on base() following root refresh
• depends upon: OAK-2259 SegmentBlob equals check should verify compaction in both directions
• is depended upon by: OAK-2045 Long running JCR session prevent live cleanup in Segment FileStore
• is related to: OAK-2045 Long running JCR session prevent live cleanup in Segment FileStore
• is related to: OAK-2271 Compaction estimation time should not depend on number of checkpoints
• relates to: OAK-2322 Compaction estimation includes all data segments
• relates to: OAK-2449 offline compaction (via oak-run) broken