Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1998

Accessible tree below a non-accessible parent are HiddenTree

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.0, 1.0.1, 1.0.2, 1.0.3
    • 1.0.4, 1.1.0
    • core
    • None

    Description

      fixing OAK-1441 introduced a regression with respect to trees that are accessible though one of their parent nodes isn't. The problem is that the fix for OAK-1441 doesn't distinguish between 'hidden' trees and trees that are not accessible.

      • Hidden Trees: the complete subtree defined by the tree starting with ":" must be hidden irrespective of the access control setup. example: Index.
      • Non-Accessible Tree: This is a matter of access control setup and it might be that a child node is readable again. Example: the version store is not accessible by default but the individual version histories (and versions) are accessible if the corresponding versionable node is.

      The second use case is broken due to the missing distinction and the fact the a HiddenTree always makes a child node hidden.

      Proposed solution: I think we have to make a clear separation between hidden trees and trees that are not accessible and which are not hidden.
      the former defines a complete tree that is hidden (current approach is correct) but for the latter we need proper permission evaluation upon access... these nodes must not be "HiddenTree"s.

      Attachments

        1. OAK-1998_(tests).patch
          12 kB
          Angela Schreiber

        Activity

          People

            mduerig Michael Dürig
            angela Angela Schreiber
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: