[OAK-1945] Unclear NodeStore.merge() contract

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: core
• Assignee: Jukka Zitting
• Reporter: Alex Deparvu
• Created: 03/Jul/14 20:07
• Updated: 06/Oct/14 04:09
• Resolved: 07/Jul/14 17:54

Description

The SegmentMK doesn't respect the #merge contract when there is a builder that has no local changes passed in.
This popped-up while I was reworking the restore parts and with the new compaction code, the only option is to pass in a NodeState#Builder builder which is considered by the #merge method as a noop and therefore ignored.

(update: See comments below)

Issue Links

• blocks: OAK-1946 Restore: "Attempt to read external blob" error