Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1945

Unclear NodeStore.merge() contract

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: core
    • Labels:
      None

      Description

      The SegmentMK doesn't respect the #merge contract when there is a builder that has no local changes passed in.
      This popped-up while I was reworking the restore parts and with the new compaction code, the only option is to pass in a NodeState#Builder builder which is considered by the #merge method as a noop and therefore ignored.

      (update: See comments below)

        Attachments

        1. MergeTest.java.patch
          1 kB
          Alex Deparvu

          Issue Links

            Activity

              People

              • Assignee:
                jukkaz Jukka Zitting
                Reporter:
                stillalex Alex Deparvu
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: