Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-1387

Pass CommitInfo to commit hooks, editors and validators

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.17
    • Component/s: core
    • Labels:
      None

      Description

      In OAK-144 we introduced the CommitInfo object for observation purposes. It's passed along with custom commit hooks to the NodeStore.merge().

      It turns out that the custom commit hooks coming from AbstractRoot.getCommitHook() are constructed using information that could well be passed through the CommitInfo object. This would simplify things as all hooks that apply to a commit could be accessed through the whiteboard as normal services.

      Doing this would require us to extend the amount of information that can be passed through the CommitInfo object, and adjust the CommitHook, EditorProvider and ValidatorProvider interfaces to accept also a CommitInfo argument. None of this seems too troublesome.

      WDYT?

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              jukkaz Jukka Zitting
              Reporter:
              jukkaz Jukka Zitting

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment