Major Description
The includedPaths property of an index definition should be an array of strings.
If it is instead specified as a String, like in this example:
"includedPaths": "/a/b",
The indexing job defaults to using the / as the value for includedPaths, and therefore downloads the full node store and creates an FFS containing everything except the hidden paths. The logic that handles this case is here:
This will slow down significantly the indexing, as it will negate any benefits from using regex filtering. And even if regex filtering is not enabled or cannot be used, using / as includedPaths will also result in the FFS containing more nodes than it should, which will once again slow down the indexing job.
Suggested fix: if includedPaths is a String, treat it as a one element array and at the same time log a warning.
Additionally, apply the same fix to other properties in the index definition:
- excludedPaths
- includedPaths
- queryPaths
Attachments
Issue Links
- links to