[OAK-10149] Rebase may be expensive with many siblings

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.52.0
• Component/s: documentmk
• Assignee: Marcel Reutegger
• Reporter: Marcel Reutegger
• Created: 20/Mar/23 07:30
• Updated: 15/May/23 16:54
• Resolved: 28/Mar/23 06:48

Description

In some cases DocumentNodeStore.rebase(NodeBuilder) can be expensive when a node is added to a parent that already has many children.

There are a few other conditions that also need to be met to make the refresh expensive. Steps to reproduce are:

Create a node structure with many child nodes and save
Create a sibling to those many nodes, but not yet save
Make further transient changes until the DocumentNodeStore creates an InMemory branch. A test can also force create this branch.
Add further changes to the new node
Rebase the current builder. Now the implementation reads all siblings of the new node, while it should only check if the added node already exists.

Issue Links

• links to: GitHub Pull Request #874