Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-10

Impedance mismatch between signatures of NodeState#getChildeNodeEntries and MicroKernel#getNodes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.1
    • None
    • None

    Description

      NodeState#getChildeNodeEntries uses long for its lenght parameter while MicroKernel#getNodes uses int. In order to implement the NodeState interface on top of the Microkernel, it would be favourable if the type would be the same.

      I suggest we change it to int for both methods since a length bigger than Integer.MAX_VALUE is not realistic anyway. On a related note, I'd rename the parameter from length to count.

      Attachments

        Activity

          People

            mduerig Michael Dürig
            mduerig Michael Dürig
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: