Nutch
  1. Nutch
  2. NUTCH-865

Format source code in unique style

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 1.9
    • Component/s: build
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      We should define a standard format rules for source code/comments, then using eclipse tool to format the whole source code in the same style.

      1. NUTCH-865.patch
        1.33 MB
        Lewis John McGibbney
      2. NUTCH-865-nutchgora-rev1188268.patch
        1.39 MB
        Sebastian Nagel
      3. NUTCH-865-trunk-rev1188252.patch
        1.64 MB
        Sebastian Nagel

        Activity

        Hide
        Julien Nioche added a comment -

        The trunk (ex-Nutchbase) contains an eclipse format file eclipse-codeformat.xml which IIRC is simply the built-in "Java Conventions" formatter with the default "Mixed" tab policy with "Spaces only" and the tabulation + indentation size set to 2.

        If that's OK with everybody we should apply it to the whole of the project + check that all the classes have the license header at the same time

        Show
        Julien Nioche added a comment - The trunk (ex-Nutchbase) contains an eclipse format file eclipse-codeformat.xml which IIRC is simply the built-in "Java Conventions" formatter with the default "Mixed" tab policy with "Spaces only" and the tabulation + indentation size set to 2. If that's OK with everybody we should apply it to the whole of the project + check that all the classes have the license header at the same time
        Hide
        Lewis John McGibbney added a comment -

        My feelings are that this could turn into a pretty huge task as I'm not exactly sure what this would this entail?

        Are we to implement this moving forward prior to release of trunk, branch-1.4, both?

        Show
        Lewis John McGibbney added a comment - My feelings are that this could turn into a pretty huge task as I'm not exactly sure what this would this entail? Are we to implement this moving forward prior to release of trunk, branch-1.4, both?
        Hide
        Julien Nioche added a comment -

        That's not very complex nor huge. All it takes is to associate the code format with the project in Eclipse and apply it. This would result in a lot of files changed for sure but these changes are only syntactic so the code will behave in exactly the same way. The only time it would be used after that is prior to committing a modification to the code.

        Show
        Julien Nioche added a comment - That's not very complex nor huge. All it takes is to associate the code format with the project in Eclipse and apply it. This would result in a lot of files changed for sure but these changes are only syntactic so the code will behave in exactly the same way. The only time it would be used after that is prior to committing a modification to the code.
        Hide
        Lewis John McGibbney added a comment -

        I'm happy to have a crack at implementing in branch-1.4. Having had a look at eclipse-codeformat.xml in trunk you are right it doesn't appear to bad. If it is OK I will assign and start working on this? Thoughts...

        Show
        Lewis John McGibbney added a comment - I'm happy to have a crack at implementing in branch-1.4. Having had a look at eclipse-codeformat.xml in trunk you are right it doesn't appear to bad. If it is OK I will assign and start working on this? Thoughts...
        Hide
        Julien Nioche added a comment -

        Maybe have a look at the diffs after applying it and see if all the changes are really that necessary? I think I saw cases where the original code looked nicer than the reformated one, in particular the sections in comments lost their \n.

        Show
        Julien Nioche added a comment - Maybe have a look at the diffs after applying it and see if all the changes are really that necessary? I think I saw cases where the original code looked nicer than the reformated one, in particular the sections in comments lost their \n.
        Hide
        Markus Jelsma added a comment -

        How is this going to affect existing patches?

        I've a lot of them and am not sure a full diff will merge that well with subversion. When we added the ASL header it all went fine but that operated only in the head of the source files.

        Show
        Markus Jelsma added a comment - How is this going to affect existing patches? I've a lot of them and am not sure a full diff will merge that well with subversion. When we added the ASL header it all went fine but that operated only in the head of the source files.
        Hide
        Lewis John McGibbney added a comment -

        This is a good point Markus. To be honest, I really don't know until the task is initiated, however I think to answer that question properly we are looking at a case-per-case basis.

        The more I think about it the more similarity I think two JIRA issues bare e.g. this one and NUTCH-881 (if we are to seriously consider achieving this). It would be great to have these tasks done before the next release, however NUTCH-881 can be done in incremental stages, unfortunately it may not be the case with NUTCH-865 and a contingency period would need to be allocated to safely guarantee that no patches were effected in the process of resolving this ticket.

        Show
        Lewis John McGibbney added a comment - This is a good point Markus. To be honest, I really don't know until the task is initiated, however I think to answer that question properly we are looking at a case-per-case basis. The more I think about it the more similarity I think two JIRA issues bare e.g. this one and NUTCH-881 (if we are to seriously consider achieving this). It would be great to have these tasks done before the next release, however NUTCH-881 can be done in incremental stages, unfortunately it may not be the case with NUTCH-865 and a contingency period would need to be allocated to safely guarantee that no patches were effected in the process of resolving this ticket.
        Hide
        Markus Jelsma added a comment -

        It would be good to finish 1.4 with clean style indeed. Should we therefore not postpone this issue until we're ready to release? That would minimize impact on open issues and it wouldn't make this task any different.

        Show
        Markus Jelsma added a comment - It would be good to finish 1.4 with clean style indeed. Should we therefore not postpone this issue until we're ready to release? That would minimize impact on open issues and it wouldn't make this task any different.
        Hide
        Lewis John McGibbney added a comment -

        agreed :0)

        Show
        Lewis John McGibbney added a comment - agreed :0)
        Hide
        Markus Jelsma added a comment -

        Marked 1.4 to keep it on the radar.

        Show
        Markus Jelsma added a comment - Marked 1.4 to keep it on the radar.
        Hide
        Markus Jelsma added a comment -

        Marked as blocker for 1.4. This issue should be the addressed as the final issue.

        Show
        Markus Jelsma added a comment - Marked as blocker for 1.4. This issue should be the addressed as the final issue.
        Hide
        Lewis John McGibbney added a comment -

        OK, since the rather useless commit, I've compiled a patch using the code formatter application bundled with Eclipse. For some reason a rather nasty number of files have been skipped, these are as follows

        lewis@lewis-desktop:~$ eclipse -application org.eclipse.jdt.core.JavaCodeFormatter -config ~/ASF/trunk/eclipse-codeformat.xml ~/ASF/trunk
        Configuration Name: /home/lewis/ASF/trunk/eclipse-codeformat.xml
        Starting format job ...
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/util/TestURLUtil.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestInjector.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/CrawlDBTestUtil.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestGenerator.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/fetcher/TestFetcher.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/scoring-link/src/java/org/apache/nutch/scoring/link/LinkAnalysisScoringFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/urlmeta/src/java/org/apache/nutch/scoring/urlmeta/URLMetaScoringFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/scoring-opic/src/java/org/apache/nutch/scoring/opic/OPICScoringFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/index-static/src/java/org/apache/nutch/indexer/staticfield/StaticFieldIndexer.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/language-identifier/src/java/org/apache/nutch/analysis/lang/HTMLLanguageParser.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/tld/src/java/org/apache/nutch/scoring/tld/TLDScoringFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/subcollection/src/java/org/apache/nutch/collection/CollectionManager.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/urlfilter-domain/src/java/org/apache/nutch/urlfilter/domain/DomainURLFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/TikaConfig.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/DOMContentUtils.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/index-more/src/test/org/apache/nutch/indexer/more/TestMoreIndexingFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-html/src/java/org/apache/nutch/parse/html/DOMContentUtils.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/GenericWritableConfigurable.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/TrieStringMatcher.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainStatistics.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffixes.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/TopLevelDomain.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffix.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/ObjectCache.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/EncodingDetector.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/NodeWalker.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolNotFound.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolStatus.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/protocols/ProtocolException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLFilterException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLNormalizers.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/Metadata.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/NodeDumper.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkRank.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/WebGraph.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/Loops.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/ScoreUpdater.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilterException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilters.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReducer.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Crawl.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Injector.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Generator.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDb.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/URLPartitioner.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbMerger.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/AdaptiveFetchSchedule.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/MapWritable.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Inlinks.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/DefaultFetchSchedule.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbMerger.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/TextProfileSignature.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/NutchWritable.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingFiltersChecker.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrIndexer.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrClean.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrDeleteDuplicates.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrWriter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchDocument.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerOutputFormat.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchField.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchIndexWriterFactory.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerMapReduce.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/ExtensionPoint.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginDescriptor.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginRepository.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginManifestParser.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/Extension.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilters.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/ContentAsTextInputFormat.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilter.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/FetcherOutputFormat.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseCallable.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginList.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseOutputFormat.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseResult.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserFactory.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginsReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseException.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserChecker.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseSegment.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/NotFoundHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/SegmentHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/LogDebugHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/DelayHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/FakeHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/AbstractTestbedHandler.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcInputFormat.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcSegmentCreator.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/FreeGenerator.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/DmozParser.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/Benchmark.java. Skip the file.
        The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/CrawlDBScanner.java. Skip the file.
        Done.
        
        Show
        Lewis John McGibbney added a comment - OK, since the rather useless commit, I've compiled a patch using the code formatter application bundled with Eclipse. For some reason a rather nasty number of files have been skipped, these are as follows lewis@lewis-desktop:~$ eclipse -application org.eclipse.jdt.core.JavaCodeFormatter -config ~/ASF/trunk/eclipse-codeformat.xml ~/ASF/trunk Configuration Name: /home/lewis/ASF/trunk/eclipse-codeformat.xml Starting format job ... The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/util/TestURLUtil.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestInjector.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/CrawlDBTestUtil.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/crawl/TestGenerator.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/test/org/apache/nutch/fetcher/TestFetcher.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/scoring-link/src/java/org/apache/nutch/scoring/link/LinkAnalysisScoringFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/urlmeta/src/java/org/apache/nutch/scoring/urlmeta/URLMetaScoringFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/scoring-opic/src/java/org/apache/nutch/scoring/opic/OPICScoringFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/index- static /src/java/org/apache/nutch/indexer/staticfield/StaticFieldIndexer.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/language-identifier/src/java/org/apache/nutch/analysis/lang/HTMLLanguageParser.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/tld/src/java/org/apache/nutch/scoring/tld/TLDScoringFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/subcollection/src/java/org/apache/nutch/collection/CollectionManager.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/urlfilter-domain/src/java/org/apache/nutch/urlfilter/domain/DomainURLFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/TikaConfig.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-tika/src/java/org/apache/nutch/parse/tika/DOMContentUtils.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/index-more/src/test/org/apache/nutch/indexer/more/TestMoreIndexingFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/plugin/parse-html/src/java/org/apache/nutch/parse/html/DOMContentUtils.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/GenericWritableConfigurable.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/TrieStringMatcher.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainStatistics.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffixes.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/TopLevelDomain.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/domain/DomainSuffix.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/ObjectCache.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/EncodingDetector.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/util/NodeWalker.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolNotFound.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/protocol/ProtocolStatus.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/protocols/ProtocolException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLFilterException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/net/URLNormalizers.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/Metadata.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/metadata/SpellCheckedMetadata.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/NodeDumper.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkRank.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/WebGraph.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/Loops.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/webgraph/ScoreUpdater.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilterException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/scoring/ScoringFilters.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReducer.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Crawl.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Injector.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Generator.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDb.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/URLPartitioner.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbMerger.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/AdaptiveFetchSchedule.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/MapWritable.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/Inlinks.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/DefaultFetchSchedule.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/LinkDbFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDbMerger.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/TextProfileSignature.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/NutchWritable.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/crawl/CrawlDatum.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingFiltersChecker.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrIndexer.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrMappingReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrClean.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrDeleteDuplicates.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/solr/SolrWriter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchDocument.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerOutputFormat.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchField.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexingException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/NutchIndexWriterFactory.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/indexer/IndexerMapReduce.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/ExtensionPoint.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginDescriptor.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginRepository.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/PluginManifestParser.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/plugin/Extension.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMerger.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilters.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/ContentAsTextInputFormat.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentMergeFilter.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/segment/SegmentReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/FetcherOutputFormat.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseCallable.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginList.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseOutputFormat.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseResult.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserFactory.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParsePluginsReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseException.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParserChecker.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/parse/ParseSegment.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/NotFoundHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/SegmentHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/LogDebugHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/DelayHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/FakeHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/proxy/AbstractTestbedHandler.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcRecordReader.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcInputFormat.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/arc/ArcSegmentCreator.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/FreeGenerator.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/DmozParser.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/Benchmark.java. Skip the file. The Eclipse formatter failed to format /home/lewis/ASF/trunk/src/java/org/apache/nutch/tools/CrawlDBScanner.java. Skip the file. Done.
        Hide
        Lewis John McGibbney added a comment -

        If I can get some time on this between today and tomorrow then I'll have my best look into sorting this out in due course.

        N.B. It is a rather trivial task formatting the code as the command line call can be seen in the snippet above.

        Show
        Lewis John McGibbney added a comment - If I can get some time on this between today and tomorrow then I'll have my best look into sorting this out in due course. N.B. It is a rather trivial task formatting the code as the command line call can be seen in the snippet above.
        Hide
        Hudson added a comment -

        Integrated in Nutch-trunk-ant #57 (See https://builds.apache.org/job/Nutch-trunk-ant/57/)
        commit to address NUTCH-865, update to changes.txt and addition of eclipse-codeformat.xml

        lewismc : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186941
        Files :

        • /nutch/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Nutch-trunk-ant #57 (See https://builds.apache.org/job/Nutch-trunk-ant/57/ ) commit to address NUTCH-865 , update to changes.txt and addition of eclipse-codeformat.xml lewismc : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186941 Files : /nutch/trunk/CHANGES.txt
        Hide
        Lewis John McGibbney added a comment -

        I'm not in a position to complete this task just now, I'm trying to work from windows and its driving me insane. The new Eclipse Indigo doesn't seem to have a code formatter and using the terminal after so long aaway from it is an unbeliveable pain. Is anyone else up for having a crack at this? I apologise for the late news, I thought I would be able to follow through, but I won't be back on my linux box until next Friday! Sorry guys.

        Show
        Lewis John McGibbney added a comment - I'm not in a position to complete this task just now, I'm trying to work from windows and its driving me insane. The new Eclipse Indigo doesn't seem to have a code formatter and using the terminal after so long aaway from it is an unbeliveable pain. Is anyone else up for having a crack at this? I apologise for the late news, I thought I would be able to follow through, but I won't be back on my linux box until next Friday! Sorry guys.
        Hide
        Sebastian Nagel added a comment -

        Formatting rules (eclipse-format.xml) are applied by Eclipse Indigo from GUI:
        1. import formatting rules:
        Properties > Java Code Style > Formatter
        > Import > eclipse-format.xml
        2. in project node context menu:
        Source > Format

        Show
        Sebastian Nagel added a comment - Formatting rules (eclipse-format.xml) are applied by Eclipse Indigo from GUI: 1. import formatting rules: Properties > Java Code Style > Formatter > Import > eclipse-format.xml 2. in project node context menu: Source > Format
        Hide
        Lewis John McGibbney added a comment -

        This is excellent Sebastian. There is mention of rolling a RC possibly this week, so I'm very hopeful that this will make the cut. I hope you remembered to edit changes.txt! If not then I'm sure we will get this added at a later date.

        Show
        Lewis John McGibbney added a comment - This is excellent Sebastian. There is mention of rolling a RC possibly this week, so I'm very hopeful that this will make the cut. I hope you remembered to edit changes.txt! If not then I'm sure we will get this added at a later date.
        Hide
        Lewis John McGibbney added a comment -

        Hi Sebastian, did you check that this doesn't break the build? After checking out most recent trunk and nutchgora branch and applying patches, I'm getting test build failures! Can you (or anyone else) confirm whether this is working or not?
        It was my fear that this would be the result.

        Show
        Lewis John McGibbney added a comment - Hi Sebastian, did you check that this doesn't break the build? After checking out most recent trunk and nutchgora branch and applying patches, I'm getting test build failures! Can you (or anyone else) confirm whether this is working or not? It was my fear that this would be the result.
        Hide
        Lewis John McGibbney added a comment -

        Apologies, I think that this is environment specific to me just now. My eclipse set-up is not behaving.

        Show
        Lewis John McGibbney added a comment - Apologies, I think that this is environment specific to me just now. My eclipse set-up is not behaving.
        Hide
        Lewis John McGibbney added a comment -

        As this is a pretty substantial aesthetic edit of the codebase, it would be good to have 1 or 2 guys give the go ahead prior to any commits. Thanks

        Show
        Lewis John McGibbney added a comment - As this is a pretty substantial aesthetic edit of the codebase, it would be good to have 1 or 2 guys give the go ahead prior to any commits. Thanks
        Hide
        Markus Jelsma added a comment -

        Does it change most files? There're a load of 1.5 patches waiting for inclusion so this may yet again cause a lot of issues. I haven't got Eclipse so i cannot test it if it works well with patches.

        Can you test some patches on a modified codebase? We can also create a temp branch with modified codebase so i can try out some intrusive patches.

        Show
        Markus Jelsma added a comment - Does it change most files? There're a load of 1.5 patches waiting for inclusion so this may yet again cause a lot of issues. I haven't got Eclipse so i cannot test it if it works well with patches. Can you test some patches on a modified codebase? We can also create a temp branch with modified codebase so i can try out some intrusive patches.
        Hide
        Lewis John McGibbney added a comment -

        Yeah Markus, you're concerns are well heard. I am unable to appraise this until Friday, if we can't get any further comments for the time being I'm sure we can wait until then. In direct response to your question YES, it changes the overwhelming majority of files so the threat of something going wrong plus the legacy this leaves for existing patches is an area which needs some thought. As I said, if we can wait until Friday then I'll get right on it.

        Show
        Lewis John McGibbney added a comment - Yeah Markus, you're concerns are well heard. I am unable to appraise this until Friday, if we can't get any further comments for the time being I'm sure we can wait until then. In direct response to your question YES, it changes the overwhelming majority of files so the threat of something going wrong plus the legacy this leaves for existing patches is an area which needs some thought. As I said, if we can wait until Friday then I'll get right on it.
        Hide
        Lewis John McGibbney added a comment -

        Markus (or anyone else), the more I think about this, the more I have convinced myself that the patches will undoubtably have adverse affects on your (and everyone elses) existing patches. There are in some cases additional lines added and in other cases there are lines removed due to formatting. I would be extremely surpised if hunks were to find a place in every case. Although I cannot confirm this, I think it is safe to hope for the best but prepare for the worst. Where does this leave us with this issue???

        Show
        Lewis John McGibbney added a comment - Markus (or anyone else), the more I think about this, the more I have convinced myself that the patches will undoubtably have adverse affects on your (and everyone elses) existing patches. There are in some cases additional lines added and in other cases there are lines removed due to formatting. I would be extremely surpised if hunks were to find a place in every case. Although I cannot confirm this, I think it is safe to hope for the best but prepare for the worst. Where does this leave us with this issue???
        Hide
        Chris A. Mattmann added a comment -
        • push out to 1.5
        Show
        Chris A. Mattmann added a comment - push out to 1.5
        Hide
        Hudson added a comment -

        Integrated in Nutch-trunk #1646 (See https://builds.apache.org/job/Nutch-trunk/1646/)

        • prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done

        mattmann : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1189790
        Files :

        • /nutch/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Nutch-trunk #1646 (See https://builds.apache.org/job/Nutch-trunk/1646/ ) prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done mattmann : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1189790 Files : /nutch/trunk/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Nutch-trunk-ant #63 (See https://builds.apache.org/job/Nutch-trunk-ant/63/)

        • prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done

        mattmann : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189790
        Files :

        • /nutch/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Nutch-trunk-ant #63 (See https://builds.apache.org/job/Nutch-trunk-ant/63/ ) prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done mattmann : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189790 Files : /nutch/trunk/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in nutch-trunk-maven #3 (See https://builds.apache.org/job/nutch-trunk-maven/3/)

        • prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done
          commit to address NUTCH-865, update to changes.txt and addition of eclipse-codeformat.xml

        mattmann : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1189790
        Files :

        • /nutch/trunk/CHANGES.txt

        lewismc : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1186941
        Files :

        • /nutch/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in nutch-trunk-maven #3 (See https://builds.apache.org/job/nutch-trunk-maven/3/ ) prep changelog for RC1: 1.4 – removed entry for NUTCH-865 since it's not done commit to address NUTCH-865 , update to changes.txt and addition of eclipse-codeformat.xml mattmann : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1189790 Files : /nutch/trunk/CHANGES.txt lewismc : http://svn.apache.org/viewvc/nutch/trunk/viewvc/?view=rev&root=&revision=1186941 Files : /nutch/trunk/CHANGES.txt
        Hide
        Markus Jelsma added a comment -

        20120304-push-1.6

        Show
        Markus Jelsma added a comment - 20120304-push-1.6

          People

          • Assignee:
            Lewis John McGibbney
            Reporter:
            Pham Tuan Minh
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development