Nutch
  1. Nutch
  2. NUTCH-469

changes to geoPosition plugin to make it work on nutch 0.9

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.9.0
    • Fix Version/s: None
    • Component/s: indexer
    • Labels:
      None

      Description

      I have modified the geoPosition plugin (http://wiki.apache.org/nutch/GeoPosition) code to work with nutch 0.9. (The code was built originally using nutch 0.7.) I'd like to contribute my changes back to the nutch project. I already communicated with the code's author (Matthias Jaekle), and he agrees with my mods.

      1. geoPosition0.6_cdiff.zip
        8 kB
        Mike Schwartz
      2. geoPosition-0.5.tgz
        137 kB
        Matthias Jaekle
      3. NUTCH-469-2007-05-09.txt.gz
        112 kB
        Sami Siren

        Activity

        Show
        Markus Jelsma added a comment - Bulk close of legacy issues: http://www.lucidimagination.com/search/document/2738eeb014805854/clean_up_open_legacy_issues_in_jira
        Hide
        Julien Nioche added a comment -

        There has not been any changes to this issue since February 09 and it won't be included in 1.1
        Marking it as 'fix version : unknown'

        Show
        Julien Nioche added a comment - There has not been any changes to this issue since February 09 and it won't be included in 1.1 Marking it as 'fix version : unknown'
        Hide
        Sami Siren added a comment -

        pushing this to 1.1

        Show
        Sami Siren added a comment - pushing this to 1.1
        Hide
        Andrzej Bialecki added a comment -

        This issue was originally scheduled for 1.0, but it's still incomplete. Either we complete it within a week, or we should move it to 1.1.

        Show
        Andrzej Bialecki added a comment - This issue was originally scheduled for 1.0, but it's still incomplete. Either we complete it within a week, or we should move it to 1.1.
        Hide
        Sami Siren added a comment -

        tnahks for putting this together, I briefly checked through the .gz and patch

        -please use diffs against trunk in future, they're more easy to check (svn diff > file)
        -there is no junit tests at all, however there is tiny piece of test code in class GeoIndexingFilter, atleast this code could perhaps be moved to a junit test class
        -i replaced System.out.prints with logging statements
        -i changed some formatting
        -would it make sense to move the zip folder from conf to under plugins src/java and change the load mechanism to use (context) class loader as i believe they are quite static piece of information once generated?

        I am attaching the patch is it is now

        Show
        Sami Siren added a comment - tnahks for putting this together, I briefly checked through the .gz and patch -please use diffs against trunk in future, they're more easy to check (svn diff > file) -there is no junit tests at all, however there is tiny piece of test code in class GeoIndexingFilter, atleast this code could perhaps be moved to a junit test class -i replaced System.out.prints with logging statements -i changed some formatting -would it make sense to move the zip folder from conf to under plugins src/java and change the load mechanism to use (context) class loader as i believe they are quite static piece of information once generated? I am attaching the patch is it is now
        Hide
        Matthias Jaekle added a comment -

        Please find attached the old plugin version for nutch 0.7. Togehter with the patch of Mike the plugin should run under nutch 0.9.

        Show
        Matthias Jaekle added a comment - Please find attached the old plugin version for nutch 0.7. Togehter with the patch of Mike the plugin should run under nutch 0.9.
        Hide
        Mike Schwartz added a comment -

        I've attached the contenxt diff from geoPosition 0.5 that I'm calling geoPosition 0.6, which makes it work with nutch 0.9.

        Show
        Mike Schwartz added a comment - I've attached the contenxt diff from geoPosition 0.5 that I'm calling geoPosition 0.6, which makes it work with nutch 0.9.

          People

          • Assignee:
            Unassigned
            Reporter:
            Mike Schwartz
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development