[NUTCH-2812] Methods returning array may expose internal representation

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17
• Fix Version/s: 1.21
• Assignee: Lewis John McGibbney
• Reporter: Lewis John McGibbney
• Created: 01/Aug/20 04:10
• Updated: 30/Mar/24 17:19

Description

Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

For example org.apache.nutch.fetcher.FetchNode.getOutlinks() may expose internal representation by returning FetchNode.outlinks

There are 11 such occurrences of this bug in the codebase.

Issue Links

• links to: GitHub Pull Request #798