[NUTCH-2765] Unify and cleanup X509TrustManager

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.16
• Fix Version/s: 1.21
• Component/s: protocol
• Labels: easytask help-wanted
• Assignee: Shashanka Balakuntala Srinivasa
• Reporter: Sebastian Nagel
• Created: 23/Jan/20 13:03
• Updated: 30/Mar/24 17:19

Description

Multiple plugins use a separate implementation of the javax.net.ssl.X509TrustManager to optionally skip TLS certificate checks (NUTCH-2647).

• protocol-httpclient, protocol-http, and with NUTCH-2649 also protocol-selenium, protocol-interactiveselenium, protocol-htmlunit use identical copies of DummyX509TrustManager
  1. there should be a single class implementation either in the plugin lib-http or in the core package org.apache.nutch.net.protocols
  2. the DummyX509TrustManager needs a clean up: it still keeps a lot old stuff relating to the sun.net.ssl.X509TrustManager interface
• protocol-okhttp includes a minimalistic anonymous class implementing X509TrustManager