[NUTCH-2760] protocol-okhttp: properly record HTTP version in request message header

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.16
• Fix Version/s: 1.17
• Component/s: plugin, protocol
• Labels: patch-available
• Assignee: Sebastian Nagel
• Reporter: Sebastian Nagel
• Created: 13/Dec/19 11:35
• Updated: 28/Jan/21 13:16
• Resolved: 09/Jan/20 10:15

Description

The HTTP version in the request message tracked by the plugin protocol-okhttp (store.http.request=true) is not the version sent in the request but that received from the response.

Note that the HTTP version sent in the request may differ from that sent back in the response. One example (tracked using wget):

> wget -d https://www.kp.ru/daily/27061/4129507/
...
---request begin---
GET /daily/27061/4129507/ HTTP/1.1
User-Agent: Wget/1.20.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: www.kp.ru
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response... 
---response begin---
HTTP/1.0 200 OK
...

protocol-http uses the response version ("HTTP/1.0") also for the request:

> bin/nutch parsechecker -Dstore.http.headers=true -Dstore.http.request=true \
     -Dplugin.includes='protocol-okhttp|parse-html' https://www.kp.ru/daily/27061/4129507/
...
_request_=GET /daily/27061/4129507/ HTTP/1.0
...
_response.headers_=HTTP/1.0 200 OK
...

The protocol-http tracks the versions correctly:

> bin/nutch parsechecker -Dstore.http.headers=true -Dstore.http.request=true \
     -Dplugin.includes='protocol-http|parse-html' https://www.kp.ru/daily/27061/4129507/
...
_request_=GET /daily/27061/4129507/ HTTP/1.1
...
_response.headers_=HTTP/1.0 200 OK
...

Issue Links

• links to: GitHub Pull Request #489