[NUTCH-2695] Fix some alerts raised by LGTM

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.16
• Assignee: Sebastian Nagel
• Reporter: Malcolm Taylor
• Created: 13/Feb/19 14:05
• Updated: 28/Jan/21 13:56
• Resolved: 22/Feb/19 14:25

Description

I work for Semmle, the company behind LGTM. Our analysis of Nutch raised some alerts, and this issue is to fix a few of the more straightforward ones. (https://lgtm.com/projects/g/apache/nutch/alerts/?mode=tree).

• `Wrong NaN comparison` in Generator
• `Type mismatch on container modification` in NutchServerPoolExecutor
• `Missing format argument` in CrawlDbReader

Issue Links

• links to: GitHub Pull Request #438