[NUTCH-2475] If and else-if branches has the same condition

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2, 1.14
• Fix Version/s: 2.4, 1.16
• Component/s: plugin, protocol
• Assignee: Sebastian Nagel
• Reporter: songwanging
• Created: 08/Dec/17 16:55
• Updated: 28/Jan/21 13:56
• Resolved: 06/Jan/19 20:25

Description

Our tool DeepTect has detected a piece of buggy code snippet, in which the if and else branches has the same condition.

Path: nutch/src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/Client.java

private boolean _notBadReply(int reply) {

    if (FTPReply.isPositiveCompletion(reply)) {
      // do nothing
 ...
    } else if (reply == 451) { // FTPReply.ACTION_ABORTED
      // some ftp servers reply 451, e.g.,
      // ProFTPD [ftp.kernel.org]
      // there is second reply witing? no!
      // getReply();
    } else if (reply == 451) { // FTPReply.ACTION_ABORTED
    } else {
      // what other kind of ftp server out there?
      return false;
    }

    return true;
  }