Uploaded image for project: 'Nutch'
  1. Nutch
  2. NUTCH-1834

GeneratorMapper behavior depends on log level

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.3
    • Component/s: generator
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      In GeneratorMapper, two return statements are shifted by a line so that they end up in a if (LOG.isWarnEnabled()) block. Therefore a change of the log level will change the behavior of the generator, i.e. an URL where an IndexFilters throws an exception will still be generated.

      The attached patch removes the if block completely by using SLF4J's placeholders. This avoids the unnecessary string concatenations that made the if necessary.

        Attachments

        1. NUTCH-1834.patch
          2 kB
          Gerhard Gossen

          Activity

            People

            • Assignee:
              snagel Sebastian Nagel
              Reporter:
              gerhard.gossen Gerhard Gossen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: