Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.11
    • Component/s: parser
    • Labels:
      None

      Description

      See NUTCH-861 for a background discussion. We have changed the name in 2.x to better reflect what it does and I think we should do the same for 1.x.

      any objections?

        Activity

        Hide
        Markus Jelsma added a comment -

        -1 for another extension point
        +0 for keeping it the way it is
        +0 for renaming it and mention it in the release note with hyperlink to wiki page which describes the actual steps to migrate. These steps must be precise and correct, we don't need lots of questions on the list.

        Show
        Markus Jelsma added a comment - -1 for another extension point +0 for keeping it the way it is +0 for renaming it and mention it in the release note with hyperlink to wiki page which describes the actual steps to migrate. These steps must be precise and correct, we don't need lots of questions on the list.
        Hide
        Julien Nioche added a comment -

        Resurrecting this thread. Do we want to have 2 version + mark old one as deprecated or shall we just do it but document it in the Wiki + release notes as suggested by Markus? Am in favour of the latter as you guessed

        Show
        Julien Nioche added a comment - Resurrecting this thread. Do we want to have 2 version + mark old one as deprecated or shall we just do it but document it in the Wiki + release notes as suggested by Markus? Am in favour of the latter as you guessed
        Hide
        Julien Nioche added a comment -

        Having 2 extension points would be a bit of an overkill IMHO - there aren't any changes in the methods and people just need to do a minor change to the core and xml config which I don't think is unreasonable when moving from one version to the next as long as it is mentioned in the Wiki.

        BTW maybe we should organize the CHANGES.txt a bit differently and organise it by type of change (optimisation - bug fix - incompatible change) as done in other projects instead of simply listing the JIRAs

        Show
        Julien Nioche added a comment - Having 2 extension points would be a bit of an overkill IMHO - there aren't any changes in the methods and people just need to do a minor change to the core and xml config which I don't think is unreasonable when moving from one version to the next as long as it is mentioned in the Wiki. BTW maybe we should organize the CHANGES.txt a bit differently and organise it by type of change (optimisation - bug fix - incompatible change) as done in other projects instead of simply listing the JIRAs
        Hide
        Sebastian Nagel added a comment -

        Markus, you are right: I remember the API change of HTMLParseFilter in 1.0: it took me some hours to get the custom plugins compiled.

        • is it possible to deprecate the extension point and keep it for some time?
        • at least, place a warning in CHANGES.txt with a link to update instructions in the wiki
        Show
        Sebastian Nagel added a comment - Markus, you are right: I remember the API change of HTMLParseFilter in 1.0: it took me some hours to get the custom plugins compiled. is it possible to deprecate the extension point and keep it for some time? at least, place a warning in CHANGES.txt with a link to update instructions in the wiki
        Hide
        Markus Jelsma added a comment -

        +0 I'm fine with such a change but this will break all (custom) plugins. I am not sure some users will be very happy with this change as all references to it in plugin.xml and the classes must be updated.

        Show
        Markus Jelsma added a comment - +0 I'm fine with such a change but this will break all (custom) plugins. I am not sure some users will be very happy with this change as all references to it in plugin.xml and the classes must be updated.
        Hide
        Sebastian Nagel added a comment -

        +1

        Show
        Sebastian Nagel added a comment - +1
        Hide
        Lewis John McGibbney added a comment -

        Hi Julien. +1 for this

        Show
        Lewis John McGibbney added a comment - Hi Julien. +1 for this

          People

          • Assignee:
            Unassigned
            Reporter:
            Julien Nioche
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:

              Development