Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      If fetcher.parse or fetcher.store.content are set to false AND the write method receives an instance of Parse or Content, a NPE will be thrown.
      This usually does not happen as the Fetcher does not output a Parse or Content based on the configuration, however this class is also used by the ArcSegmentCreator which is unaware of these parameters and will output a Parse or Content instance regardless of the configuration. One option would be to make the ArcSegmentCreator aware of the fetcher.* parameters and output things accordingly but it also makes sense to modify the FetcherOutputFormat so that it checks whether a subWriter has been created before trying to use it.

      1. NUTCH-1334.patch
        0.7 kB
        Julien Nioche

        Activity

        Julien Nioche created issue -
        Hide
        Julien Nioche added a comment -

        Will commit post 1.5

        Show
        Julien Nioche added a comment - Will commit post 1.5
        Julien Nioche made changes -
        Field Original Value New Value
        Attachment NUTCH-1334.patch [ 12522768 ]
        Lewis John McGibbney made changes -
        Fix Version/s 1.7 [ 12323281 ]
        Lewis John McGibbney made changes -
        Patch Info Patch Available [ 10042 ]
        Hide
        Tejas Patil added a comment -

        As the patch was trivial (null checks) so went ahead and committed to trunk @ rev1477847. (No patch applicable for 2.x)

        Show
        Tejas Patil added a comment - As the patch was trivial (null checks) so went ahead and committed to trunk @ rev1477847. (No patch applicable for 2.x)
        Tejas Patil made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Nutch-trunk #2189 (See https://builds.apache.org/job/Nutch-trunk/2189/)
        NUTCH-1334 NPE in FetcherOutputFormat (Revision 1477847)

        Result = FAILURE
        tejasp : http://svn.apache.org/viewvc/nutch/trunk/?view=rev&rev=1477847
        Files :

        • /nutch/trunk/CHANGES.txt
        • /nutch/trunk/src/java/org/apache/nutch/fetcher/FetcherOutputFormat.java
        Show
        Hudson added a comment - Integrated in Nutch-trunk #2189 (See https://builds.apache.org/job/Nutch-trunk/2189/ ) NUTCH-1334 NPE in FetcherOutputFormat (Revision 1477847) Result = FAILURE tejasp : http://svn.apache.org/viewvc/nutch/trunk/?view=rev&rev=1477847 Files : /nutch/trunk/CHANGES.txt /nutch/trunk/src/java/org/apache/nutch/fetcher/FetcherOutputFormat.java
        Lewis John McGibbney made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Julien Nioche
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development