Nutch
  1. Nutch
  2. NUTCH-1304

GeneratorMapper.java dosen't return when skipping and already generated mark

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: nutchgora
    • Fix Version/s: nutchgora
    • Component/s: generator
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      GeneratorMapper.java dosen't return when skipping and already generated mark

      1. NUTCH-1304-test.patch
        2 kB
        Dan Rosher
      2. NUTCH-1304.patch
        0.5 kB
        Dan Rosher

        Activity

        Hide
        Lewis John McGibbney added a comment -

        +1 for commit. I'll wait until this afternoon to hear back from anyone else before doing so. Thanks Dan.

        Show
        Lewis John McGibbney added a comment - +1 for commit. I'll wait until this afternoon to hear back from anyone else before doing so. Thanks Dan.
        Hide
        Lewis John McGibbney added a comment -

        Committed @ revision 1298444 in Nutchgora branch

        Thank you again Dan for the patch.

        Show
        Lewis John McGibbney added a comment - Committed @ revision 1298444 in Nutchgora branch Thank you again Dan for the patch.
        Hide
        Lewis John McGibbney added a comment -

        Please close this one off when you have time Dan you.

        Show
        Lewis John McGibbney added a comment - Please close this one off when you have time Dan you.
        Hide
        Dan Rosher added a comment -

        Cheers Lewis

        Show
        Dan Rosher added a comment - Cheers Lewis
        Hide
        Hudson added a comment -

        Integrated in Nutch-nutchgora #187 (See https://builds.apache.org/job/Nutch-nutchgora/187/)
        commit to address NUTCH-1304 and update to CHANGES.txt (Revision 1298444)

        Result = FAILURE
        lewismc :
        Files :

        • /nutch/branches/nutchgora/CHANGES.txt
        • /nutch/branches/nutchgora/src/java/org/apache/nutch/crawl/GeneratorMapper.java
        Show
        Hudson added a comment - Integrated in Nutch-nutchgora #187 (See https://builds.apache.org/job/Nutch-nutchgora/187/ ) commit to address NUTCH-1304 and update to CHANGES.txt (Revision 1298444) Result = FAILURE lewismc : Files : /nutch/branches/nutchgora/CHANGES.txt /nutch/branches/nutchgora/src/java/org/apache/nutch/crawl/GeneratorMapper.java
        Hide
        Lewis John McGibbney added a comment -

        Slight problem with TestGenerator after committing.
        Log output for the build can be seen below

        https://builds.apache.org/job/Nutch-nutchgora/187/consoleText

        Any chance you could have a look Dan so we can include this patch? Thank you

        Show
        Lewis John McGibbney added a comment - Slight problem with TestGenerator after committing. Log output for the build can be seen below https://builds.apache.org/job/Nutch-nutchgora/187/consoleText Any chance you could have a look Dan so we can include this patch? Thank you
        Hide
        Dan Rosher added a comment -

        No worries I'll have a look

        Show
        Dan Rosher added a comment - No worries I'll have a look
        Hide
        Dan Rosher added a comment -

        I've attached a patch for the test, and re-ran all the tests.

        Show
        Dan Rosher added a comment - I've attached a patch for the test, and re-ran all the tests.
        Hide
        Lewis John McGibbney added a comment -

        Yep this is now fixed, thanks again Dan.

        Show
        Lewis John McGibbney added a comment - Yep this is now fixed, thanks again Dan.

          People

          • Assignee:
            Unassigned
            Reporter:
            Dan Rosher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development