Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Activity

      Hide
      lufeng added a comment -

      Hi Tejas, thanks for your reminding. but there still some new line character in the patch file like this

      • }
        + }
      • +

      Do you know how to remove these characters. i use svn diff command to generate patch file. Or Can i edit the patch file to remove these characters?

      Show
      lufeng added a comment - Hi Tejas, thanks for your reminding. but there still some new line character in the patch file like this } + } + Do you know how to remove these characters. i use svn diff command to generate patch file. Or Can i edit the patch file to remove these characters?
      Hide
      lufeng added a comment -

      migrate WebGraph to new MR api

      Show
      lufeng added a comment - migrate WebGraph to new MR api
      Hide
      Tejas Patil added a comment -

      Hi Lufeng,
      One suggestion: There are lot of places in the patch where a diff is generated due to space / tab character. eg.

      -      if (line.hasOption("filter")) {
      +     if (line.hasOption("filter")) {

      Can you kindly remove all such diffs and generate a new patch ? This would make it easy to spot the actual changes done.

      Show
      Tejas Patil added a comment - Hi Lufeng, One suggestion: There are lot of places in the patch where a diff is generated due to space / tab character. eg. - if (line.hasOption("filter")) { + if (line.hasOption("filter")) { Can you kindly remove all such diffs and generate a new patch ? This would make it easy to spot the actual changes done.
      Hide
      lufeng added a comment -

      migrate WebGraph to new MR API patch

      Show
      lufeng added a comment - migrate WebGraph to new MR API patch
      Hide
      Markus Jelsma added a comment -

      20120304-push-1.6

      Show
      Markus Jelsma added a comment - 20120304-push-1.6

        People

        • Assignee:
          lufeng
          Reporter:
          Markus Jelsma
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:

            Development