Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4, nutchgora
    • Fix Version/s: 1.4
    • Component/s: indexer
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      We need an option to prevent a job from sending a commit to Solr. A commit can take a lot of resources (cache warming) and it's not always necessary to commit after index, dedup or clean, especially if they are run immediately after the other.

      1. NUTCH-1000-1.4.patch
        7 kB
        Markus Jelsma
      2. NUTCH-1000-1.4-2.patch
        1 kB
        Markus Jelsma

        Issue Links

          Activity

          Hide
          Markus Jelsma added a comment -

          Patch for solrindex, solrdedup and solrclean. Tested and confirmed to work.

          Show
          Markus Jelsma added a comment - Patch for solrindex, solrdedup and solrclean. Tested and confirmed to work.
          Hide
          Markus Jelsma added a comment -

          Note for the reviewer: the noCommit literal should be a constant in SolrConstants. Any other objections or thoughts or remarks?

          Show
          Markus Jelsma added a comment - Note for the reviewer: the noCommit literal should be a constant in SolrConstants. Any other objections or thoughts or remarks?
          Hide
          Markus Jelsma added a comment -

          If there are no objections, i'd like to commit this one.

          Show
          Markus Jelsma added a comment - If there are no objections, i'd like to commit this one.
          Hide
          Lewis John McGibbney added a comment -

          Hi Markus,

          I'm not on a work station where I can try this one out just now, can someone else please comment?

          Show
          Lewis John McGibbney added a comment - Hi Markus, I'm not on a work station where I can try this one out just now, can someone else please comment?
          Hide
          Markus Jelsma added a comment -

          Committed for 1.4 in rev. 1139357. For trunk i need to rewrite the patch and solrclean isn't available in trunk atm.

          Show
          Markus Jelsma added a comment - Committed for 1.4 in rev. 1139357. For trunk i need to rewrite the patch and solrclean isn't available in trunk atm.
          Hide
          Markus Jelsma added a comment -

          Added patch with method overrides for indexer and dedup. The lack of them caused the crawl.java to fail. It didn't show up in my builds before just now.

          Show
          Markus Jelsma added a comment - Added patch with method overrides for indexer and dedup. The lack of them caused the crawl.java to fail. It didn't show up in my builds before just now.
          Hide
          Markus Jelsma added a comment -

          Committed for 1.4 in rev. 1140685.

          Show
          Markus Jelsma added a comment - Committed for 1.4 in rev. 1140685.
          Hide
          Markus Jelsma added a comment -

          Resolved for 1.4.

          Show
          Markus Jelsma added a comment - Resolved for 1.4.

            People

            • Assignee:
              Markus Jelsma
              Reporter:
              Markus Jelsma
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development