Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0-beta1
    • fraction

    Description

      This ML post makes suggestions and points to potential issues with that class.

      A.o. things,

      • there seems to be some code overlap between the constructors and the getReducedFraction method (and the latter should probably be private anyways),
      • method percentageValue is not very useful,
      • a lot of constants should be removed,
      • serialVersionUID should be updated, and moved to the top of the declaration list.

      Attachments

        Activity

          People

            Unassigned Unassigned
            erans Gilles Sadowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: