[NPANDAY-477] If a solution has content files outside "regular" projects, several first-chance exceptions occur in Connect.cs

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4-incubating
• Fix Version/s: 1.5.0-incubating
• Component/s: Visual Studio Add-in

Environment

Apache Maven 2.2.1 (r801777; 2009-08-06 22:16:01+0300)
Java version: 1.6.0_23
Java home: C:\Program Files (x86)\Java\jdk1.6.0_23\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7" version: "6.1" arch: "x86" Family: "windows"

Visual Studio 2010 SP1/.NET Framework 4

• Assignee: Brett Porter
• Reporter: Stoyan Damov
• Created: 03/Nov/11 19:09
• Updated: 05/Jan/12 01:36
• Resolved: 05/Jan/12 01:36

Description

A solution containing one or more files outside any projects (e.g. a new mavenized solution, where I unhide the files and include the parent pom) will crash the addin with several first-chance exceptions (but these are swallowed by COM). The solution has a (I believe hidden) project called "Solution Items", which is not handled properly.

1. ProjectItemEvents_ItemAdded creates new PomHelperUtility(_applicationObject.Solution, CurrentSelectedProject), where CurrentSelectedProject is null which crashes with NullReferenceException in PomHelperUtility's ctor.
2. SigningEvents_SignatureAdded crashes in doc.Load(project.FullName) with ArgumentException, because FullName is an empty string.
3. attachReferenceEvent crashes with InvalidCastException at VSProject2 classProject = (VSProject2)project.Object

I suggest developers debug the addin every now and then with first-chance exceptions enabled to catch such errors.