NPanday
  1. NPanday
  2. NPANDAY-425

Msbuild Plugin does not have frameworkVersion configuration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not a Problem
    • Affects Version/s: None
    • Fix Version/s: 1.5.0-incubating
    • Component/s: Maven Plugins
    • Labels:
      None

      Description

      At the moment it only uses the first instance of the .Net Framework in the environment path. Msbuild should respect the configuration of frameworkVersion.

        Issue Links

          Activity

          Hide
          Brett Porter added a comment -

          In my opinion, this should be revised. It doesn't make sense to force MSBuild to use a particular framework version to run with - consider the case of a project file created with VS 2010 which will refer to the new tools, but target an older framework. This fails under this patch.

          The patch doesn't actually provide any benefit unless it were setting the /toolsversion or /p:TargetFramework command line arguments.

          We should defer this until we have a separate concept of the tools version and the target version.

          Show
          Brett Porter added a comment - In my opinion, this should be revised. It doesn't make sense to force MSBuild to use a particular framework version to run with - consider the case of a project file created with VS 2010 which will refer to the new tools, but target an older framework. This fails under this patch. The patch doesn't actually provide any benefit unless it were setting the /toolsversion or /p:TargetFramework command line arguments. We should defer this until we have a separate concept of the tools version and the target version.
          Hide
          Joe Ocaba added a comment -

          Fixed in trunk, added in the framework configuration. This should also be reflected once the plugin is shifted to java code.

          Show
          Joe Ocaba added a comment - Fixed in trunk, added in the framework configuration. This should also be reflected once the plugin is shifted to java code.
          Hide
          Joe Ocaba added a comment -

          Yup, but for the meantime until it is moved to java, I will just add the configuration needed for the msbuild plugin.

          Show
          Joe Ocaba added a comment - Yup, but for the meantime until it is moved to java, I will just add the configuration needed for the msbuild plugin.
          Hide
          Lars Corneliussen added a comment -

          Do you mean 1.4.1?

          It is currently a netplugin, but shouldn't be. There is an issue for that somewhere.

          Show
          Lars Corneliussen added a comment - Do you mean 1.4.1? It is currently a netplugin, but shouldn't be. There is an issue for that somewhere.

            People

            • Assignee:
              Brett Porter
              Reporter:
              Joe Ocaba
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development