[NLPCRAFT-179] Fix license header/comment per mentor's suggestions.

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7.3
• Assignee: Aaron Radzinski
• Reporter: Aaron Radzinski
• Created: 23/Nov/20 22:09
• Updated: 27/Dec/21 20:51
• Resolved: 30/Nov/20 02:17

Description

For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and
NOTICE, thanks) if the statement "Code almost entirely based on work of
..." is indeed true, then I believe it is usually clearer to leave the
original license header in the source file and perhaps amend with
"Subsequent changes Copyright by the NLPCraft team and made under the
ASLv2..." but what you have is possibly okay - just not as clear. IANAL,
but my understanding is that you have the obligation to make it clear that
the requirements the original author requested for use of that file in
source form etc. are still in play and aren't overwritten by slapping the
ASLv2 header at the front of the file.