[NIFI-9786] KeyStoreUtils.isStoreValid() suppresses exceptions without logging when trying to open a keystore

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.16.0
• Assignee: Tamas Horvath
• Reporter: Peter Gyori
• Created: 10/Mar/22 17:09
• Updated: 21/Mar/22 15:54
• Resolved: 21/Mar/22 15:52

Description

KeyStoreUtils.isStoreValid() simply returns false if the keystore cannot be opened e.g. because the password is wrong. There is no log entry about why the keystore is not valid.

As a result when SslContextFactory.getTrustManagers() method attempts to read a trust store file using the configured properties, if the password is wrong, the method is not informed why, and only throws a TlsException stating "The truststore properties are not valid".

It would be useful to add debug-level logging to KeyStoreUtils.isStoreValid() to log the reason for the keystore being invalid.

Issue Links

• links to: GitHub Pull Request #5884