[NIFI-920] UnpackContent can continuously rollback on java.nio.InvalidPathException

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.7.0
• Labels: patch
• Assignee: Joe Gresock
• Reporter: Brandon Rhys DeVries
• Created: 02/Sep/15 14:56
• Updated: 27/Jun/16 17:51
• Resolved: 27/Jun/16 17:51

Description

In UnpackContent, file.toPath() is called without catching java.nio.file.InvalidPathException:

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L265#L266

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L316#L318

This bubbles up out of the processor and causes a rollback, instead of simply failing the file in the processor.

This could be fixed in each "Unpacker" implementation (possibly by catching and wrapping in a ProcessException), or the catch in the OnTrigger method here:

https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java#L238

... could simply be changed to "catch (final ProcessException | InvalidPathException e)". Whoever implements the fix can think that all the way through.