Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-797

PutS3Object logs the URL as HTTP when the URL is HTTPS

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: Extensions
    • Labels:

      Description

      The PutS3Object reports to provenance that it uses an HTTP url, when the default for the S3 is actually HTTPS. This makes it pretty misleading as to what is happening.

      This is verified HTTPS via wireshark and a code review.

      https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java;h=24c82dd036f68b6cc1ed1df39d9a89b4cf7c0555;hb=HEAD

      171 final String url = "http://" + bucket + ".s3.amazonaws.com/" + key;\r
      172 final long millis = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);\r
      173 session.getProvenanceReporter().send(flowFile, url, millis);\r

      https://github.com/aws/aws-sdk-java/blob/8397ef2731c9ea57de1a529a2e3991eebb96b257/aws-java-sdk-core/src/main/java/com/amazonaws/ClientConfiguration.java

      Lines 104-110:
      /**

      • The protocol to use when connecting to Amazon Web Services.
      • <p>
      • The default configuration is to use HTTPS for all requests for increased
      • security.
        */
        private Protocol protocol = Protocol.HTTPS;

        Attachments

        1. NIFI-797.000.patch
          7 kB
          Tony Kurc

          Activity

            People

            • Assignee:
              tkurc Tony Kurc
              Reporter:
              rahst12 Ryan Hendrickson
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: