Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-6758

create bundle coordinate map in separate phase

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10.0
    • Component/s: Core Framework
    • Labels:
      None

      Description

      In NarUnpacker

      https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java#L131

      a bundleCoordinate map is populated during a for loop which un-packs the nars found in extension work dir.

      This is great.

      However if we want to optimize nifi size, we could keep only the un-packed the nars, delete the original nar archive files, and save hundreds of MBs of diskspace.

      In this case, the bundle-coordinate map is not populated, as the nar files are no longer present, only their unpacked , directory version are present.
      Such empty bundle-coordinate map will result in an empty ExtensionMapping which is returned, and is supplied to downstream components, eg.:

      jettyserver puts it on context for web docs servlet
      https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java#L1005

      and the nifi-web-docs DocumentationController uses it:

      https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-docs/src/main/java/org/apache/nifi/web/docs/DocumentationController.java#L60

      In such case, the resulting effect is that when the user does a right click on a processor, and clicks view-usage

      None of the processors are showing in the help.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                andrewsmith87 Endre Kovacs
                Reporter:
                andrewsmith87 Endre Kovacs
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h