[NIFI-6758] create bundle coordinate map in separate phase

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: Core Framework
• Assignee: Endre Kovacs
• Reporter: Endre Kovacs
• Created: 09/Oct/19 17:18
• Updated: 10/Oct/19 19:04
• Resolved: 10/Oct/19 15:37

Description

In NarUnpacker

https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java#L131

a bundleCoordinate map is populated during a for loop which un-packs the nars found in extension work dir.

This is great.

However if we want to optimize nifi size, we could keep only the un-packed the nars, delete the original nar archive files, and save hundreds of MBs of diskspace.

In this case, the bundle-coordinate map is not populated, as the nar files are no longer present, only their unpacked , directory version are present.
Such empty bundle-coordinate map will result in an empty ExtensionMapping which is returned, and is supplied to downstream components, eg.:

jettyserver puts it on context for web docs servlet
https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java#L1005

and the nifi-web-docs DocumentationController uses it:

https://github.com/apache/nifi/blob/9a496fe9d2681fca06fb6f071d0fa39d71bc5268/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-docs/src/main/java/org/apache/nifi/web/docs/DocumentationController.java#L60

In such case, the resulting effect is that when the user does a right click on a processor, and clicks view-usage

None of the processors are showing in the help.

Issue Links

• links to: GitHub Pull Request #3806