[NIFI-659] rat-plugin needs to be configured to exclude child and parent items

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.2.0
• Component/s: Tools and Build
• Assignee: Joe Witt
• Reporter: Joe Witt
• Created: 04/Jun/15 15:52
• Updated: 04/Jun/15 16:30
• Resolved: 04/Jun/15 16:30

Description

Presently when doing the proper -Pcontrib-check on patches and such we can run into issues with modules that implement their own excludes above and beyond what the nifi-parent excludes. This is due to how the configuration override/merge/append mechanism works in Maven 3. What we really want it to do is 'append' to the child's list whatever was in the parents list. So for example:

            <plugin>
                <groupId>org.apache.rat</groupId>
                <artifactId>apache-rat-plugin</artifactId>
                <configuration>
                    <excludes>
                        <exclude>src/test/resources/conf/0bytes.xml</exclude>
                        <exclude>src/test/resources/conf/termination-only.xml</exclude>
                        <exclude>src/test/resources/hello.txt</exclude>
                        <exclude>src/test/resources/old-swap-file.swap</exclude>
                    </excludes>
                </configuration>
            </plugin>

would work as we really want it to if it were

            <plugin>
                <groupId>org.apache.rat</groupId>
                <artifactId>apache-rat-plugin</artifactId>
                <configuration>
                    <excludes combine.children="append">
                        <exclude>src/test/resources/conf/0bytes.xml</exclude>
                        <exclude>src/test/resources/conf/termination-only.xml</exclude>
                        <exclude>src/test/resources/hello.txt</exclude>
                        <exclude>src/test/resources/old-swap-file.swap</exclude>
                    </excludes>
                </configuration>
            </plugin>