[NIFI-6416] WriteAheadFlowFileRepository.swapFlowFilesIn() not removing swapLocationSuffixes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.2
• Fix Version/s: 1.10.0
• Component/s: Core Framework
• Assignee: Brandon Rhys DeVries
• Reporter: Brandon Rhys DeVries
• Created: 02/Jul/19 18:20
• Updated: 04/Sep/19 21:51
• Resolved: 04/Sep/19 21:51

Description

WriteAheadFlowFileRepository maintains a list of swapLocationSuffixes.  This is added to when records are swapped out, and removed from when records are swapped in when the repo is updated[1].  However, the swapFlowFilesIn method[2] appears to be adding instead of removing the specified swap location. 

Specifically:

synchronized (this.swapLocationSuffixes) {
    this.swapLocationSuffixes.add(normalizeSwapLocation(swapLocation));
}

Should be:

synchronized (this.swapLocationSuffixes) {
    this.swapLocationSuffixes.remove(normalizeSwapLocation(swapLocation));
}

 

 

[1] https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L372-L377

[2]  https://github.com/apache/nifi/blob/f08c2ee43f39584b7d4e76d61d7d4aaa889068fd/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java#L518

Issue Links

• is related to: NIFI-4775 Create a FlowFile repo backed by RocksDB
• links to: GitHub Pull Request #3654