Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-6296

Improve instructions on submitting PR commits

    XMLWordPrintableJSON

    Details

      Description

      Some contributors have been confused about how to provide additional commits when a PR reviewer asks for changes because the Contributor Guide and PR template emphasize a "single, squashed commit".

      I'll update these documents to explain that the initial commit should be a single, squashed commit, but additional changes should be made on the same branch and pushed (without force pushing/overwriting) so the reviewers can see the changes. The eventual committer will squash and rebase (unless this is non-trivial, in which case they can ask the author to perform this task).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                alopresto Andy LoPresto
                Reporter:
                alopresto Andy LoPresto
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m