[NIFI-6296] Improve instructions on submitting PR commits

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.2
• Fix Version/s: 1.10.0
• Component/s: Documentation & Website
• Labels: documentation
• Assignee: Andy LoPresto
• Reporter: Andy LoPresto
• Created: 14/May/19 02:29
• Updated: 24/May/19 21:57
• Resolved: 24/May/19 21:57

Description

Some contributors have been confused about how to provide additional commits when a PR reviewer asks for changes because the Contributor Guide and PR template emphasize a "single, squashed commit".

I'll update these documents to explain that the initial commit should be a single, squashed commit, but additional changes should be made on the same branch and pushed (without force pushing/overwriting) so the reviewers can see the changes. The eventual committer will squash and rebase (unless this is non-trivial, in which case they can ask the author to perform this task).

Issue Links

• links to: GitHub Pull Request #3475