[NIFI-5662] AvroTypeUtil Decimal support using Fixed Error

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.9.0
• Component/s: Core Framework
• Environment: RHEL 7.5 ; JDK 1.8.182
• Assignee: Unassigned
• Reporter: Gideon Korir
• Created: 05/Oct/18 06:56
• Updated: 17/Nov/18 15:37
• Resolved: 17/Nov/18 15:37

Description

When the decimal is specified as fixed in the Avro schema, AvroTypeUtils converts the decimal into a ByteBuffer instead of a GenericFixed.

The code:

return new Conversions.DecimalConversion().toBytes(decimal, fieldSchema, logicalType)

 Should be:

return fieldSchema.getType() == Type.BYTES
? new Conversions.DecimalConversion().toBytes(decimal, fieldSchema, logicalType)
: new Conversions.DecimalConversion().toFixed(decimal, fieldSchema, logicalType);

The former causes the AvroRecordSetWriter to fail with the error: 

org.apache.avro.file.DataFileWriter$AppendWriteException: java.lang.ClassCastException: java.nio.HeapByteBuffer cannot be cast to org.apache.avro.generic.GenericFixed

Issue Links

• links to: GitHub Pull Request #3175