[NIFI-5588] Unable to set indefinite max wait time on DBCPConnectionPool

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.8.0
• Component/s: Extensions
• Environment: macOS, Java 8
• Assignee: Pierre Villard
• Reporter: Colin Dean
• Created: 12/Sep/18 02:28
• Updated: 25/Sep/18 13:33
• Resolved: 25/Sep/18 06:51

Description

The DBCPConnectionPool controller service accepts a "Max Wait Time" that configures 

The maximum amount of time that the pool will wait (when there are no available connections) for a connection to be returned before failing, or -1 to wait indefinitely.

This value must validate as a time period. There is no valid way to set -1 with the current validator.

The validator in use is StandardValidators.TIME_PERIOD_VALIDATOR. The TIME_PERIOD_VALIDATOR uses a regex built in FormatUtils that must have a time unit:

public static final String TIME_DURATION_REGEX = "(\\d+)\\s*(" + VALID_TIME_UNITS + ")";

The regex does not allow for an value such as -1 or -1 secs, etc.

The obvious workaround is to set that very high.

Issue Links

• links to: GitHub Pull Request #3022