[NIFI-5377] StandardNiFiServiceFacade: Recursive method call allows for Stack Overflow when a circular reference exists

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0, 1.7.1
• Component/s: Core Framework
• Assignee: Mark Bean
• Reporter: Jon Kessler
• Created: 05/Jul/18 15:20
• Updated: 12/Jul/18 01:56
• Resolved: 10/Jul/18 14:01

Description

At a minimum, when you attempt to view a list of controller services in the gui this specific method is called to obtain a set of referenced controller service identifiers. If there is a circular dependency in that set, you end up with an infinite loop that ultimately results the user being redirected to an error page in the gui.

The method in question is findControllerServiceReferencingComponentIdentifiers. It checks to see if each node has been visited already but does not add them to the set until after recursively calling itself again. If the line "visited.add(node);" is moved above the method call, this will be resolved.

Issue Links

• links to: GitHub Pull Request #2847