[NIFI-5368] Referenced Controller Services not being validated in Mock Framework

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0, 1.7.1
• Component/s: Core Framework, Tools and Build
• Assignee: Mark Payne
• Reporter: Mark Payne
• Created: 03/Jul/18 13:15
• Updated: 12/Jul/18 01:31
• Resolved: 10/Jul/18 15:24

Description

During the refactoring for NIFI-950, the validation of of referenced Controller Services moved from AbstractConfigurableComponent to AbstractComponentNode. While this works fine for NiFi's lifecycle, it does cause problems with the Mock Framework. Because the Mock Framework does not create an AbstractComponentNode, only the AbstractConfigurableComponent, and validates that component directly, referenced Controller Services are not validated. Additionally, they are not (and never have been) validated when enabled.

We should update the Mock Framework such that when TestRunner.enableControllerService(ControllerService) is called, we first validate the Controller Service before enabling it.

Additionally, in the AbstractConfigurableComponent, or in the Mock Framework itself, verify that all referenced services are in fact enabled when validating the component.

Issue Links

• links to: GitHub Pull Request #2873