Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-4625

Add External Versioning to PutElasticSearch5 Processor

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.5.0
    • Component/s: Core Framework
    • Environment:
      All

      Description

      Currently the PutElasticSearch5 processor does not support external versioning.
      The idea would be to add a property that follows the same logic as the Id property, and allows index documents with an externally controlled version.

      I've changed the code already and added some tests. Right now the changes proposed are:

      • Add a new property Version in the processor block.
      • Change the Index operation to support the versioning number and versioning type = external
      • Check if the versioning is used with other operation types, fail if so.
        (Idea behind this is that the bulk api doest not support external versioning for any other operation except Index)

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r157098293

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
          final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue();
          final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue();
          final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue();
          + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null;
          — End diff –

          My mistake, was thinking of PropertyDescriptor.asLong(), if you change from an attribute to using the property (with EL support, see above comments). asLong() doesn't apply here unless you change from requiring an attribute vs a property value, sorry about that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r157098293 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue(); final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue(); final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue(); + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null; — End diff – My mistake, was thinking of PropertyDescriptor.asLong(), if you change from an attribute to using the property (with EL support, see above comments). asLong() doesn't apply here unless you change from requiring an attribute vs a property value, sorry about that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r157098024

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -129,6 +130,12 @@
          .defaultValue("100")
          .expressionLanguageSupported(true)
          .build();
          +
          + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder()
          + .name("Version").displayName("Version Attribute")
          + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning")
          + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
          — End diff –

          That was an unfortunate oversight on my part, thinking you'd need a value for ID, and we've been a bit stuck with it ever since (until the next major version release perhaps). If the value is not required, then I think EL support should suffice?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r157098024 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -129,6 +130,12 @@ .defaultValue("100") .expressionLanguageSupported(true) .build(); + + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder() + .name("Version").displayName("Version Attribute") + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning") + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR) — End diff – That was an unfortunate oversight on my part, thinking you'd need a value for ID, and we've been a bit stuck with it ever since (until the next major version release perhaps). If the value is not required, then I think EL support should suffice?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on the issue:

          https://github.com/apache/nifi/pull/2287

          Seems to pass without issues !
          Used the following cmd : `mvn clean package -pl nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar -am -Pcontrib-check` .

          Should I do more changes ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on the issue: https://github.com/apache/nifi/pull/2287 Seems to pass without issues ! Used the following cmd : `mvn clean package -pl nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar -am -Pcontrib-check` . Should I do more changes ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on the issue:

          https://github.com/apache/nifi/pull/2287

          Don’t worry about those, go ahead and run the Maven command from the bundle directory that you changed (nifi-elasticsearch-bundle), if contrib-check passes it’s all good

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2287 Don’t worry about those, go ahead and run the Maven command from the bundle directory that you changed (nifi-elasticsearch-bundle), if contrib-check passes it’s all good
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on the issue:

          https://github.com/apache/nifi/pull/2287

          Failed Travis build bc of nifi-kafka-0-9-processors .......................... FAILURE ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on the issue: https://github.com/apache/nifi/pull/2287 Failed Travis build bc of nifi-kafka-0-9-processors .......................... FAILURE ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152841740

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
          final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue();
          final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue();
          final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue();
          + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null;
          — End diff –

          For some reason can't use the .as Long(), file.getAttribute(version_attribute) returns a String per default. Suggestions ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152841740 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue(); final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue(); final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue(); + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null; — End diff – For some reason can't use the .as Long(), file.getAttribute(version_attribute) returns a String per default. Suggestions ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152831157

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearch5.java —
          @@ -36,6 +36,7 @@
          import org.elasticsearch.common.io.stream.StreamInput;
          import org.elasticsearch.common.settings.Settings;
          import org.elasticsearch.common.transport.TransportAddress;
          +import org.elasticsearch.index.engine.VersionConflictEngineException;
          — End diff –

          Removing this, and running the maven build with that flag !

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152831157 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearch5.java — @@ -36,6 +36,7 @@ import org.elasticsearch.common.io.stream.StreamInput; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.common.transport.TransportAddress; +import org.elasticsearch.index.engine.VersionConflictEngineException; — End diff – Removing this, and running the maven build with that flag !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152830029

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
          final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue();
          final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue();
          final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue();
          + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null;
          — End diff –

          From my understanding this field is suppose to take the flowfile attribute name, thats why I went with ATTRIBUTE_KEY_VALIDATOR .

          I'm updating the code to use .asLong() instead !

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152830029 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue(); final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue(); final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue(); + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null; — End diff – From my understanding this field is suppose to take the flowfile attribute name, thats why I went with ATTRIBUTE_KEY_VALIDATOR . I'm updating the code to use .asLong() instead !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152829112

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -129,6 +130,12 @@
          .defaultValue("100")
          .expressionLanguageSupported(true)
          .build();
          +
          + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder()
          + .name("Version").displayName("Version Attribute")
          + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning")
          + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
          — End diff –

          Idea here was to follow the same logic as the ID_ATTRIBUTE so not to break pattern. But not having the field required, so you can Update/Upsert documents.
          Actually I think the Id should be expression enabled and even allowed to be null - You can index docs without an ID.

          What change would you sugest ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152829112 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -129,6 +130,12 @@ .defaultValue("100") .expressionLanguageSupported(true) .build(); + + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder() + .name("Version").displayName("Version Attribute") + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning") + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR) — End diff – Idea here was to follow the same logic as the ID_ATTRIBUTE so not to break pattern. But not having the field required, so you can Update/Upsert documents. Actually I think the Id should be expression enabled and even allowed to be null - You can index docs without an ID. What change would you sugest ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152591692

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearch5.java —
          @@ -36,6 +36,7 @@
          import org.elasticsearch.common.io.stream.StreamInput;
          import org.elasticsearch.common.settings.Settings;
          import org.elasticsearch.common.transport.TransportAddress;
          +import org.elasticsearch.index.engine.VersionConflictEngineException;
          — End diff –

          I see this imported but not used, Travis hasn't finished building but I expect some CheckStyle violations here and in the other file(s). Please run your maven build of this bundle with `-Pcontrib-check` , this will let you know if there are formatting violations, files without the correct headers, etc. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152591692 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearch5.java — @@ -36,6 +36,7 @@ import org.elasticsearch.common.io.stream.StreamInput; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.common.transport.TransportAddress; +import org.elasticsearch.index.engine.VersionConflictEngineException; — End diff – I see this imported but not used, Travis hasn't finished building but I expect some CheckStyle violations here and in the other file(s). Please run your maven build of this bundle with `-Pcontrib-check` , this will let you know if there are formatting violations, files without the correct headers, etc. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152590804

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
          final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue();
          final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue();
          final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue();
          + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null;
          — End diff –

          FYI you could also call `file.getAttribute(version_attribute).asLong()`. Also if the field is supposed to contain a Long value (if set), then you should consider using a LONG_VALIDATOR for that field (rather than the NON_EMPTY_VALIDATOR I suggested in my other comment). This will avoid a possible NumberFormatException if someone enters invalid input.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152590804 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -196,6 +205,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final String index = context.getProperty(INDEX).evaluateAttributeExpressions(file).getValue(); final String docType = context.getProperty(TYPE).evaluateAttributeExpressions(file).getValue(); final String indexOp = context.getProperty(INDEX_OP).evaluateAttributeExpressions(file).getValue(); + final Long version = version_attribute != null ? Long.parseLong(file.getAttribute(version_attribute)) : null; — End diff – FYI you could also call `file.getAttribute(version_attribute).asLong()`. Also if the field is supposed to contain a Long value (if set), then you should consider using a LONG_VALIDATOR for that field (rather than the NON_EMPTY_VALIDATOR I suggested in my other comment). This will avoid a possible NumberFormatException if someone enters invalid input.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2287#discussion_r152586939

          — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java —
          @@ -129,6 +130,12 @@
          .defaultValue("100")
          .expressionLanguageSupported(true)
          .build();
          +
          + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder()
          + .name("Version").displayName("Version Attribute")
          + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning")
          + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
          — End diff –

          If this property is not required, does it need to refer to an attribute? If instead you support expression language and set the validator to NON_EMPTY_VALIDATOR, then you can still set the Version to the value of an attribute by using expression language, or you can hardcode it without needing an incoming attribute, in the case where it will/should always be the same

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2287#discussion_r152586939 — Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java — @@ -129,6 +130,12 @@ .defaultValue("100") .expressionLanguageSupported(true) .build(); + + public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder() + .name("Version").displayName("Version Attribute") + .description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning") + .required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR) — End diff – If this property is not required, does it need to refer to an attribute? If instead you support expression language and set the validator to NON_EMPTY_VALIDATOR, then you can still set the Version to the value of an attribute by using expression language, or you can hardcode it without needing an incoming attribute, in the case where it will/should always be the same
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user otherview opened a pull request:

          https://github.com/apache/nifi/pull/2287

          NIFI-4625 - Added Version to the PutElastic5 Processor. Added Testing around the version usage.

          Changelist:
          -Added a new Version Property to the Processor
          . Not required
          . No Expression Language
          -Changed the Chained ifs for Index Op into a switch
          -Ensured that version can only be used with the index operation
          -Added testing in the testfile around the last change.

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ y] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [y ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [ y] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [y ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/otherview/nifi master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2287.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2287


          commit a503c4caeb3c30f5907d2a4b39da60a322bd5370
          Author: Pedro G <otherview@gmail.com>
          Date: 2017-11-22T14:20:12Z

          /* Added Version to the PutElastic5 Processor. Added Testing around the version usage.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user otherview opened a pull request: https://github.com/apache/nifi/pull/2287 NIFI-4625 - Added Version to the PutElastic5 Processor. Added Testing around the version usage. Changelist: -Added a new Version Property to the Processor . Not required . No Expression Language -Changed the Chained ifs for Index Op into a switch -Ensured that version can only be used with the index operation -Added testing in the testfile around the last change. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [y ] Has your PR been rebased against the latest commit within the target branch (typically master)? [ y] Is your initial contribution a single, squashed commit? For code changes: [y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [y ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/otherview/nifi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2287 commit a503c4caeb3c30f5907d2a4b39da60a322bd5370 Author: Pedro G <otherview@gmail.com> Date: 2017-11-22T14:20:12Z /* Added Version to the PutElastic5 Processor. Added Testing around the version usage.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview closed the pull request at:

          https://github.com/apache/nifi/pull/2282

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview closed the pull request at: https://github.com/apache/nifi/pull/2282
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user otherview commented on the issue:

          https://github.com/apache/nifi/pull/2282

          Closing this PR and adding a new pull request, as I didn't find a way to swiftly change the files.

          Show
          githubbot ASF GitHub Bot added a comment - Github user otherview commented on the issue: https://github.com/apache/nifi/pull/2282 Closing this PR and adding a new pull request, as I didn't find a way to swiftly change the files.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user joewitt commented on the issue:

          https://github.com/apache/nifi/pull/2282

          @otherview please update the PR to keep the previous formatting/whitespace so that your changes are more clear/obvious. Right now for a reviewer this looks like a pretty large changeset to go through. It is easier/faster of course if the changes are specific to your necessary functional change only.

          Show
          githubbot ASF GitHub Bot added a comment - Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2282 @otherview please update the PR to keep the previous formatting/whitespace so that your changes are more clear/obvious. Right now for a reviewer this looks like a pretty large changeset to go through. It is easier/faster of course if the changes are specific to your necessary functional change only.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user otherview opened a pull request:

          https://github.com/apache/nifi/pull/2282

          NIFI-4625 - Added Version to the PutElastic5 Processor. Added Testing around the …

          …version usage.

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [y ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ y] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [y ] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ y] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [y ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/otherview/nifi master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2282.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2282


          commit ddd856a8ea9865a2fe1093a6a2863f348c8abb1f
          Author: Pedro G <otherview@gmail.com>
          Date: 2017-11-21T15:26:31Z

          Added Version to the PutElastic5 Processor. Added Testing around the version usage.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user otherview opened a pull request: https://github.com/apache/nifi/pull/2282 NIFI-4625 - Added Version to the PutElastic5 Processor. Added Testing around the … …version usage. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [y ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ y] Has your PR been rebased against the latest commit within the target branch (typically master)? [y ] Is your initial contribution a single, squashed commit? For code changes: [y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ y] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [y ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/otherview/nifi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2282.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2282 commit ddd856a8ea9865a2fe1093a6a2863f348c8abb1f Author: Pedro G <otherview@gmail.com> Date: 2017-11-21T15:26:31Z Added Version to the PutElastic5 Processor. Added Testing around the version usage.

            People

            • Assignee:
              otherview Pedro Gomes
              Reporter:
              otherview Pedro Gomes
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development