Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.2.0, 1.3.0, 1.4.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      We should support some date related functions in record path. At a minimum I think having a format function like:

      format( /someField, 'yyyy-MM-dd', defaultValue)
      

      The main use case for this is using PartitionRecord to partition by month, day, or hour on a date field.

      Currently you have treat the date as a string and use a sub-string operation to get the part you are interested in, which also assumes the date is in a string form in the first place.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bbende commented on the issue:

          https://github.com/apache/nifi/pull/2221

          Yea I forgot about the timezone, but that should be added as an optional parameter, and that will make use of the unused method that Matt pointed out

          Show
          githubbot ASF GitHub Bot added a comment - Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2221 Yea I forgot about the timezone, but that should be added as an optional parameter, and that will make use of the unused method that Matt pointed out
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pvillard31 commented on the issue:

          https://github.com/apache/nifi/pull/2221

          Just a quick comment: would it make sense to also add support for time zone as we do in expression language? Can be done in a separate JIRA though.

          Show
          githubbot ASF GitHub Bot added a comment - Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2221 Just a quick comment: would it make sense to also add support for time zone as we do in expression language? Can be done in a separate JIRA though.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mattyb149 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2221#discussion_r146999573

          — Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java —
          @@ -346,4 +356,19 @@ private static RecordPathFilter createFunctionFilter(final Tree functionTree, fi

          return argPaths;
          }
          +
          + private static RecordPathSegment[] getArgPaths(final Tree argumentListTree, final int minCount, final int maxCount, final String functionName, final boolean absolute) {
          — End diff –

          Is this used anywhere?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2221#discussion_r146999573 — Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java — @@ -346,4 +356,19 @@ private static RecordPathFilter createFunctionFilter(final Tree functionTree, fi return argPaths; } + + private static RecordPathSegment[] getArgPaths(final Tree argumentListTree, final int minCount, final int maxCount, final String functionName, final boolean absolute) { — End diff – Is this used anywhere?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bbende opened a pull request:

          https://github.com/apache/nifi/pull/2221

          NIFI-4506 Adding toDate and format functions to record path

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [ ] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bbende/nifi NIFI-4506

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2221.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2221


          commit 228c129fd8ead682a730505d996e70f9fb761e0f
          Author: Bryan Bende <bbende@apache.org>
          Date: 2017-10-20T18:08:56Z

          NIFI-4506 Adding toDate and format functions to record path


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2221 NIFI-4506 Adding toDate and format functions to record path Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? [ ] Is your initial contribution a single, squashed commit? For code changes: [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi NIFI-4506 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2221 commit 228c129fd8ead682a730505d996e70f9fb761e0f Author: Bryan Bende <bbende@apache.org> Date: 2017-10-20T18:08:56Z NIFI-4506 Adding toDate and format functions to record path

            People

            • Assignee:
              bende Bryan Bende
              Reporter:
              bende Bryan Bende
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development