Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-4372

Wait processor - recommend prioritizer in documentation

    Details

      Description

      When using the Wait processor, the use of a connection prioritizer (FIFO for instance) on the wait relationship should be recommended in the processor documentation. When having tens of thousands of flow files in the wait relationship, not using a prioritizer could lead to flow files not being released when signal is notified and generate expired flow files.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user pvillard31 opened a pull request:

          https://github.com/apache/nifi/pull/2139

          NIFI-4372 Wait processor - recommend prioritizer in documentation

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [ ] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/pvillard31/nifi NIFI-4372

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2139.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2139


          commit 87cb16eb73cc10ab5ac6d5346842f03411d86309
          Author: Pierre Villard <pierre.villard.fr@gmail.com>
          Date: 2017-09-09T17:21:47Z

          NIFI-4372 Wait processor - recommend prioritizer in documentation


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2139 NIFI-4372 Wait processor - recommend prioritizer in documentation Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? [ ] Is your initial contribution a single, squashed commit? For code changes: [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-4372 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2139.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2139 commit 87cb16eb73cc10ab5ac6d5346842f03411d86309 Author: Pierre Villard <pierre.villard.fr@gmail.com> Date: 2017-09-09T17:21:47Z NIFI-4372 Wait processor - recommend prioritizer in documentation
          Hide
          markap14 Mark Payne added a comment -

          Pierre Villard - we should never have a condition where a FlowFile is not released when a signal is triggered. If we do, then adding a prioritizer won't change this. This very much sounds like a bug, and perhaps changing the ordering of the queue was avoiding the triggering of the bug for you, but I think we've got a deeper issue here.

          Show
          markap14 Mark Payne added a comment - Pierre Villard - we should never have a condition where a FlowFile is not released when a signal is triggered. If we do, then adding a prioritizer won't change this. This very much sounds like a bug, and perhaps changing the ordering of the queue was avoiding the triggering of the bug for you, but I think we've got a deeper issue here.
          Hide
          markap14 Mark Payne added a comment -

          I was able to replicate the issue that you describe above. Looking into the processor it looks like it is calling ProcessSession.get(FlowFileFilter) and the StandardProcessSession appears not to look through any FlowFiles that are swapped out. I will create a separate JIRA for that issue.

          Show
          markap14 Mark Payne added a comment - I was able to replicate the issue that you describe above. Looking into the processor it looks like it is calling ProcessSession.get(FlowFileFilter) and the StandardProcessSession appears not to look through any FlowFiles that are swapped out. I will create a separate JIRA for that issue.
          Hide
          markap14 Mark Payne added a comment -

          Pierre Villard after looking into this more, I appear to have misunderstood how the Wait processor was working. Based on the design of it, adding a FirstInFirstOut prioritizer is definitely necessary, regardless of the issue that I mentioned above.

          Show
          markap14 Mark Payne added a comment - Pierre Villard after looking into this more, I appear to have misunderstood how the Wait processor was working. Based on the design of it, adding a FirstInFirstOut prioritizer is definitely necessary, regardless of the issue that I mentioned above.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ea2c91f9d052016390c07bbc06fd7f8c734d373b in nifi's branch refs/heads/master from Pierre Villard
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ea2c91f ]

          NIFI-4372 Wait processor - recommend prioritizer in documentation. This closes #2139.

          Show
          jira-bot ASF subversion and git services added a comment - Commit ea2c91f9d052016390c07bbc06fd7f8c734d373b in nifi's branch refs/heads/master from Pierre Villard [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ea2c91f ] NIFI-4372 Wait processor - recommend prioritizer in documentation. This closes #2139.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/2139

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2139
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user markap14 commented on the issue:

          https://github.com/apache/nifi/pull/2139

          Thanks for pointing this out, @pvillard31. Confirmed that I was able to replicate the issue and that it is resolved once I use the FIFO Prioritizer. Have merged this changed to master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2139 Thanks for pointing this out, @pvillard31. Confirmed that I was able to replicate the issue and that it is resolved once I use the FIFO Prioritizer. Have merged this changed to master.

            People

            • Assignee:
              pvillard Pierre Villard
              Reporter:
              pvillard Pierre Villard
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development