Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-4361

Server fails to start during recovery upon full disk

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.0, 1.2.0, 1.3.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Our disk filled up – we then freed up some space and restarted, but the server failed to start up due to:

      ERROR [main] o.a.nifi.controller.StandardFlowService Failed to load flow from cluster due to: org.apache.nifi.cluster.ConnectionException: Failed to connect node to cluster due to: java.lang.IllegalStateException: Signaled end to recovery, but there are more recovery files for Partition in directory /data/nifi/flowfile_repository/partition-8

      at org.wali.MinimalLockingWriteAheadLog$Partition.endRecovery(MinimalLockingWriteAheadLog.java:1047) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
      at org.wali.MinimalLockingWriteAheadLog.recoverFromEdits(MinimalLockingWriteAheadLog.java:487) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]
      at org.wali.MinimalLockingWriteAheadLog.recoverRecords(MinimalLockingWriteAheadLog.java:301) ~[nifi-write-ahead-log-1.1.0.jar:1.1.0]

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user gresockj opened a pull request:

          https://github.com/apache/nifi/pull/2133

          NIFI-4361: Fixing early recovery shutdown due to EOF in walog partition

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [x] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [x] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gresockj/nifi NIFI-4361

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2133.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2133


          commit 7457228bcfa7a2ec862f5395983fc4c5c3032faf
          Author: Joe Gresock <joseph.gresock@lmco.com>
          Date: 2017-09-07T14:32:43Z

          NIFI-4361: Fixing early recovery shutdown due to EOF in walog partition


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user gresockj opened a pull request: https://github.com/apache/nifi/pull/2133 NIFI-4361 : Fixing early recovery shutdown due to EOF in walog partition Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [x] Has your PR been rebased against the latest commit within the target branch (typically master)? [x] Is your initial contribution a single, squashed commit? For code changes: [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gresockj/nifi NIFI-4361 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2133 commit 7457228bcfa7a2ec862f5395983fc4c5c3032faf Author: Joe Gresock <joseph.gresock@lmco.com> Date: 2017-09-07T14:32:43Z NIFI-4361 : Fixing early recovery shutdown due to EOF in walog partition
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user markap14 commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2133#discussion_r137837796

          — Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java —
          @@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo
          subsequentTransactionId = nextPartition.getNextRecoverableTransactionId();
          } catch (final IOException e) {
          logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; "

          • + "assuming crash and ignoring this transaction",
            + + "attempting to get the next recoverable transaction ID",
              • End diff –

          @gresockj thanks for the contribution! The only concern that I have here is that this update assumes that we will never get more than 1 IOException in a row... I think we need to continue looping until we've run out of 'recovery files' for the partition.

          Show
          githubbot ASF GitHub Bot added a comment - Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2133#discussion_r137837796 — Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java — @@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo subsequentTransactionId = nextPartition.getNextRecoverableTransactionId(); } catch (final IOException e) { logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; " + "assuming crash and ignoring this transaction", + + "attempting to get the next recoverable transaction ID", End diff – @gresockj thanks for the contribution! The only concern that I have here is that this update assumes that we will never get more than 1 IOException in a row... I think we need to continue looping until we've run out of 'recovery files' for the partition.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gresockj commented on a diff in the pull request:

          https://github.com/apache/nifi/pull/2133#discussion_r137839524

          — Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java —
          @@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo
          subsequentTransactionId = nextPartition.getNextRecoverableTransactionId();
          } catch (final IOException e) {
          logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; "

          • + "assuming crash and ignoring this transaction",
            + + "attempting to get the next recoverable transaction ID",
              • End diff –

          I had a thought that this would be necessary, but I'm not sure what the ending condition would be. How would you determine that we've run out of recovery files?

          Show
          githubbot ASF GitHub Bot added a comment - Github user gresockj commented on a diff in the pull request: https://github.com/apache/nifi/pull/2133#discussion_r137839524 — Diff: nifi-commons/nifi-write-ahead-log/src/main/java/org/wali/MinimalLockingWriteAheadLog.java — @@ -474,8 +474,15 @@ private void recoverFromEdits(final Map<Object, T> modifiableRecordMap, final Lo subsequentTransactionId = nextPartition.getNextRecoverableTransactionId(); } catch (final IOException e) { logger.error("{} unexpectedly found End-of-File when reading from {} for Transaction ID {}; " + "assuming crash and ignoring this transaction", + + "attempting to get the next recoverable transaction ID", End diff – I had a thought that this would be necessary, but I'm not sure what the ending condition would be. How would you determine that we've run out of recovery files?

            People

            • Assignee:
              jgresock Joseph Gresock
              Reporter:
              jgresock Joseph Gresock
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development