Details

      Description

      The immediately actionable items are:

      • org.apache.logging.log4j:log4j-core in nifi-storm-spout 2.1 -> 2.8.2
      • org.apache.poi:poi in nifi-email-processors 3.14 -> 3.15
      • org.apache.logging.log4j:log4j-core in nifi-elasticsearch-5-processors 2.7 -> 2.8.2
      • org.springframework:spring-web in nifi-jetty 4.2.4.RELEASE -> 4.3.10.RELEASE
      • org.springframework:spring-web in nifi-jetty 4.2.4.RELEASE -> 4.3.10.RELEASE
      • org.apache.derby:derby in nifi-kite-processors 10.11.1.1 -> 10.12.1.1 (already excluded)
      • com.fasterxml.jackson.core:jackson-core in nifi-azure-processors 2.6.0 -> 2.8.6
      • com.fasterxml.jackson.core:jackson-core in nifi-expression-language 2.6.1 -> 2.8.6
      • com.fasterxml.jackson.core:jackson-core in nifi-standard-utils 2.6.2 -> 2.8.6
      • com.fasterxml.jackson.core:jackson-core in nifi-hwx-schema-registry 2.7.3 -> 2.8.6
      • com.fasterxml.jackson.core:jackson-core in nifi-solr-processors 2.5.4 -> 2.8.6

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user alopresto opened a pull request:

          https://github.com/apache/nifi/pull/2084

          NIFI-4297 Updated dependency versions

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [ ] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [ ] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/alopresto/nifi NIFI-4297

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/2084.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2084


          commit adfa1da0791033c41b377af3c229c04bb1233f0d
          Author: Andy LoPresto <alopresto@apache.org>
          Date: 2017-08-14T22:02:22Z

          NIFI-4297 Upgraded immediately actionable dependency versions from Meterian report.
          All tests pass.

          commit 5549a6ed7dee50029e42bce9919282bc15082114
          Author: Andy LoPresto <alopresto@apache.org>
          Date: 2017-08-14T22:34:33Z

          NIFI-4297 Upgraded jackson-core test dependencies for HBase and Elasticsearch modules.
          Only 3 instances of jackson-core < 2.8.6 (Google Cloud Platform and Spark Receiver modules).
          All tests pass.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2084 NIFI-4297 Updated dependency versions Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? [ ] Is your initial contribution a single, squashed commit? For code changes: [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-4297 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2084.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2084 commit adfa1da0791033c41b377af3c229c04bb1233f0d Author: Andy LoPresto <alopresto@apache.org> Date: 2017-08-14T22:02:22Z NIFI-4297 Upgraded immediately actionable dependency versions from Meterian report. All tests pass. commit 5549a6ed7dee50029e42bce9919282bc15082114 Author: Andy LoPresto <alopresto@apache.org> Date: 2017-08-14T22:34:33Z NIFI-4297 Upgraded jackson-core test dependencies for HBase and Elasticsearch modules. Only 3 instances of jackson-core < 2.8.6 (Google Cloud Platform and Spark Receiver modules). All tests pass.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/2084

          I [published the results](https://gist.github.com/alopresto/df899c1e379fe48d830663313cf34db4) of `mvn dependency:tree` on my local machine, and the reviewer can verify that the only instances of `jackson-core` < 2.8.6 are:

          • `nifi-gcp-processors - google-http-client-jackson2 - 2.1.3`
          • `nifi-gcp-nar - google-http-client-jackson2 - 2.1.3`
          • `nifi-spark-receiver - com.fasterxml.jackson.core.jackson-databind - 2.6.5`

          by using the regex `jackson-core:jar:2.[^8]`.

          All unit tests pass.

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2084 I [published the results] ( https://gist.github.com/alopresto/df899c1e379fe48d830663313cf34db4 ) of `mvn dependency:tree` on my local machine, and the reviewer can verify that the only instances of `jackson-core` < 2.8.6 are: `nifi-gcp-processors - google-http-client-jackson2 - 2.1.3` `nifi-gcp-nar - google-http-client-jackson2 - 2.1.3` `nifi-spark-receiver - com.fasterxml.jackson.core.jackson-databind - 2.6.5` by using the regex `jackson-core:jar:2. [^8] `. All unit tests pass.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/2084

          I ran the `mvn dependency:tree` on current `master` and compared to the output above. There are only 2 differences aside from the version upgrades:

          1. `aopalliance:aopalliance:1.0` moves from `org.springframework:spring-aop:jar:4.2.4.RELEASE` to `org.springframework.security:spring-security-core:jar:4.2.3.RELEASE` but has the same version and license as currently exists.
          1. `ring-cors:ring-cors:0.1.5` is a new transitive dependency brought in by `org.apache.storm:storm-core:jar:1.1.1` after it was upgraded from `1.0.1`. `ring-cors` uses the [EPL 1.0](https://eclipse.org/org/documents/epl-v10.php), which is considered [Category B by Apache](https://www.apache.org/legal/resolved.html#category-b). I believe this is acceptable from the statement:

          > For small amounts of source that is directly consumed by the ASF product at runtime in source form, and for which that source is unmodified and unlikely to be changed anyway (say, by virtue of being specified by a standard), inclusion of appropriately labeled source is also permitted.

          There is no existing `LICENSE` or `NOTICE` file in the `nifi-external` or `nifi-external/nifi-storm-spout` modules, which is where this code is brought in. @joewitt , please advise on proper license/notice model to follow/copy here.

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2084 I ran the `mvn dependency:tree` on current `master` and compared to the output above. There are only 2 differences aside from the version upgrades: 1. `aopalliance:aopalliance:1.0` moves from `org.springframework:spring-aop:jar:4.2.4.RELEASE` to `org.springframework.security:spring-security-core:jar:4.2.3.RELEASE` but has the same version and license as currently exists. 1. `ring-cors:ring-cors:0.1.5` is a new transitive dependency brought in by `org.apache.storm:storm-core:jar:1.1.1` after it was upgraded from `1.0.1`. `ring-cors` uses the [EPL 1.0] ( https://eclipse.org/org/documents/epl-v10.php ), which is considered [Category B by Apache] ( https://www.apache.org/legal/resolved.html#category-b ). I believe this is acceptable from the statement: > For small amounts of source that is directly consumed by the ASF product at runtime in source form, and for which that source is unmodified and unlikely to be changed anyway (say, by virtue of being specified by a standard), inclusion of appropriately labeled source is also permitted. There is no existing `LICENSE` or `NOTICE` file in the `nifi-external` or `nifi-external/nifi-storm-spout` modules, which is where this code is brought in. @joewitt , please advise on proper license/notice model to follow/copy here.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user joewitt commented on the issue:

          https://github.com/apache/nifi/pull/2084

          @mcgilman @alopresto the lack of L&N on that is because we're not publishing a bundled artifact for it (like we do with nars). We're simply putting source up or the binary of our external but then normal dep/maven magic takes over. So, we're ok as-is and having a cat-b dependency is still fair game. Once someone pulls in our library (which depends on that stuff) then they would have to consider the EPL implications. In short, i think we're good here for L&N based on andy's above assessment.

          Show
          githubbot ASF GitHub Bot added a comment - Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2084 @mcgilman @alopresto the lack of L&N on that is because we're not publishing a bundled artifact for it (like we do with nars). We're simply putting source up or the binary of our external but then normal dep/maven magic takes over. So, we're ok as-is and having a cat-b dependency is still fair game. Once someone pulls in our library (which depends on that stuff) then they would have to consider the EPL implications. In short, i think we're good here for L&N based on andy's above assessment.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mcgilman commented on the issue:

          https://github.com/apache/nifi/pull/2084

          @joewitt Thanks for reviewing the L&N concerns...

          @alopresto Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2084 @joewitt Thanks for reviewing the L&N concerns... @alopresto Reviewing...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mcgilman commented on the issue:

          https://github.com/apache/nifi/pull/2084

          @alopresto I believe the exclusions for the solr processors are incorrect. `jackson-core` has been excluded but not explicitly added. Also, I noticed that the change to `jackson-annotations` made in the root pom, affects the version of `jackson-annotations` which `solr-solrj` brings in transitively. It appears that prior to this PR it also overriding (2.6.1 vs 2.5.4). Because the use of jackson is so widespread and the behavior of dependency management with regards to transitive dependencies, I'm wondering if it makes to remove `jackson-annotations` and allow individual modules to pull it in using the `jackson.version` property introduced here. Thoughts?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2084 @alopresto I believe the exclusions for the solr processors are incorrect. `jackson-core` has been excluded but not explicitly added. Also, I noticed that the change to `jackson-annotations` made in the root pom, affects the version of `jackson-annotations` which `solr-solrj` brings in transitively. It appears that prior to this PR it also overriding (2.6.1 vs 2.5.4). Because the use of jackson is so widespread and the behavior of dependency management with regards to transitive dependencies, I'm wondering if it makes to remove `jackson-annotations` and allow individual modules to pull it in using the `jackson.version` property introduced here. Thoughts?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/2084

          Thanks @mcgilman and @joewitt . I rebased against `1.5.0-SNAPSHOT master`, added the explicit dependency on `jackson-core` in `nifi-solr-processors/pom.xml` and removed `jackson-databind` from the `<dependencyManagement>` block in `nifi/pom.xml` and explicitly referenced the `$

          {jackson.version}

          ` variable throughout the children poms. The full build works, and I verified that not only does it compile, the project seems to be able to correctly perform JSON parsing in a variety of ways (used [this template](https://gist.github.com/alopresto/63c087854c5300f7c0763ce118c1eef6)) to verify.

          ![Web Server and JSON Parsing Template](https://user-images.githubusercontent.com/798465/31206880-7cf37a8a-a92f-11e7-928b-5a43c0900bb1.png)

          I still need to evaluate if `org.codehaus.jackson:jackson-mapper-asl:1.9.13` is used anywhere, as discussion between @mcgilman and myself [revealed it is replaced by `com.fasterxml.jackson.core:jackson-core:2.9.1`](https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-mapper-asl/1.9.13).

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2084 Thanks @mcgilman and @joewitt . I rebased against `1.5.0-SNAPSHOT master`, added the explicit dependency on `jackson-core` in `nifi-solr-processors/pom.xml` and removed `jackson-databind` from the `<dependencyManagement>` block in `nifi/pom.xml` and explicitly referenced the `$ {jackson.version} ` variable throughout the children poms. The full build works, and I verified that not only does it compile, the project seems to be able to correctly perform JSON parsing in a variety of ways (used [this template] ( https://gist.github.com/alopresto/63c087854c5300f7c0763ce118c1eef6 )) to verify. ! [Web Server and JSON Parsing Template] ( https://user-images.githubusercontent.com/798465/31206880-7cf37a8a-a92f-11e7-928b-5a43c0900bb1.png ) I still need to evaluate if `org.codehaus.jackson:jackson-mapper-asl:1.9.13` is used anywhere, as discussion between @mcgilman and myself [revealed it is replaced by `com.fasterxml.jackson.core:jackson-core:2.9.1`] ( https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-mapper-asl/1.9.13 ).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/2084

          Matt and I discussed and I will try to minimize further differences in order to get this merged in a working state, as he is currently upgrading the version of Jersey and it changes a lot of the jackson dependencies as well. In that vein, rather than attempting to remove the `jackson-mapper-asl` completely, I will remove it from dependency management and explicitly list the version in child poms. New commit forthcoming.

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2084 Matt and I discussed and I will try to minimize further differences in order to get this merged in a working state, as he is currently upgrading the version of Jersey and it changes a lot of the jackson dependencies as well. In that vein, rather than attempting to remove the `jackson-mapper-asl` completely, I will remove it from dependency management and explicitly list the version in child poms. New commit forthcoming.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/2084

          I believe this is ready to be merged @mcgilman .

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2084 I believe this is ready to be merged @mcgilman .
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d4168f5ff1c5afb03f3797ad4573aef9512d4aff in nifi's branch refs/heads/master from Andy LoPresto
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d4168f5 ]

          NIFI-4297

          • Upgraded immediately actionable dependency versions from Meterian report.
          • Upgraded jackson-core test dependencies for HBase and Elasticsearch modules.
          • Only 3 instances of jackson-core < 2.8.6 (Google Cloud Platform and Spark Receiver modules).
          • Upgraded version of poi dependency in nifi-email-processors to 3.16.
          • Resolving dependency issues after rebasing against 1.5.0-SNAPSHOT.
          • Removed jackson-databind from <dependencyManagement> block in nifi/pom.xml and added explicit reference to $ {jackson.version}

            in all referenced artifacts.

          • Removed jackson-mapper-asl from <dependencyManagement> block in nifi/pom.xml and added explicit reference to $ {jackson.old.version}

            in all referenced artifacts.

          • Removed Jasypt from <dependencyManagement> and added explicit version in test dependency for legacy compatibility.
          • This closes #2084
          Show
          jira-bot ASF subversion and git services added a comment - Commit d4168f5ff1c5afb03f3797ad4573aef9512d4aff in nifi's branch refs/heads/master from Andy LoPresto [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d4168f5 ] NIFI-4297 Upgraded immediately actionable dependency versions from Meterian report. Upgraded jackson-core test dependencies for HBase and Elasticsearch modules. Only 3 instances of jackson-core < 2.8.6 (Google Cloud Platform and Spark Receiver modules). Upgraded version of poi dependency in nifi-email-processors to 3.16. Resolving dependency issues after rebasing against 1.5.0-SNAPSHOT. Removed jackson-databind from <dependencyManagement> block in nifi/pom.xml and added explicit reference to $ {jackson.version} in all referenced artifacts. Removed jackson-mapper-asl from <dependencyManagement> block in nifi/pom.xml and added explicit reference to $ {jackson.old.version} in all referenced artifacts. Removed Jasypt from <dependencyManagement> and added explicit version in test dependency for legacy compatibility. This closes #2084
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/2084

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2084
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mcgilman commented on the issue:

          https://github.com/apache/nifi/pull/2084

          Thanks @alopresto! Looks good. This has been merged to master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2084 Thanks @alopresto! Looks good. This has been merged to master.

            People

            • Assignee:
              alopresto Andy LoPresto
              Reporter:
              alopresto Andy LoPresto
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development