[NIFI-424] Processors / Controller Services should not be able to directly call ControllerService.initialize and ControllerService.onPropertyModified

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1.0
• Component/s: Core Framework
• Assignee: Brandon Rhys DeVries
• Reporter: Mark Payne
• Created: 16/Mar/15 19:20
• Updated: 31/Mar/15 20:11
• Resolved: 31/Mar/15 13:38

Description

Currently, when a component obtains a Controller Service, it could call onPropertyModified or initialize, which can cause some weird and unexpected behaviors, since these methods are expected to be called only within the constraints of a well-defined component lifecycle. We should prevent this by intercepting the method call and throwing an IllegalStateException unless the method call is coming from the framework.

Implementation details: This can be achieved by looking at the StandardControllerServiceProvider, which implements all Controller Service interfaces with proxies. In that proxy, it should simply throw an Exception. Then, just ensure that the framework never calls the proxy but only calls directly into the implementing class.