Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      NIFI-3863 aims to implement a LookupRecord processor along with two implementations of LookupServices, one for enriching records with Geo information from IP addresses, and a static one from a list of provided key/value pairs.

      A very flexible and powerful improvement would be to offer a ScriptedLookupService, where the same scripting capabilities that are available to InvokeScriptedProcessor, ScriptedReader and ScriptedRecordSetWriter are available to prototype/implement a LookupService for use by the LookupRecord processor.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mattyb149 opened a pull request:

          https://github.com/apache/nifi/pull/1828

          NIFI-3938: Added ScriptedLookupService, some refactor for reusable scripting classes

          Moved some code common to scripted ControllerServices out into AbstractScriptedControllerService. Also the Scripting helper classes were in the processor package but are useful elsewhere, so I moved that and changed the visibility of some protected methods.

              1. For all changes:
          • [x] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [x] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [x] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [x] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mattyb149/nifi NIFI-3938

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1828.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1828


          commit e3eb44fa1d6be545528e1985359b0cc57f5c6e0a
          Author: Matt Burgess <mattyb149@apache.org>
          Date: 2017-05-19T14:46:26Z

          NIFI-3938: Added ScriptedLookupService, some refactor for reusable scripting classes


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1828 NIFI-3938 : Added ScriptedLookupService, some refactor for reusable scripting classes Moved some code common to scripted ControllerServices out into AbstractScriptedControllerService. Also the Scripting helper classes were in the processor package but are useful elsewhere, so I moved that and changed the visibility of some protected methods. For all changes: [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [x] Has your PR been rebased against the latest commit within the target branch (typically master)? [x] Is your initial contribution a single, squashed commit? For code changes: [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [x] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [x] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-3938 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1828 commit e3eb44fa1d6be545528e1985359b0cc57f5c6e0a Author: Matt Burgess <mattyb149@apache.org> Date: 2017-05-19T14:46:26Z NIFI-3938 : Added ScriptedLookupService, some refactor for reusable scripting classes
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/1828

          Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1828 Reviewing...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user alopresto commented on the issue:

          https://github.com/apache/nifi/pull/1828

          Built with `contrib-check` and all tests pass. With Matt's help, I created a schema registry with a defined schema, generated flowfiles with CSV formatted data (a hockey roster), and used `SplitRecord` with the `CSVReader` and `CSVRecordSetWriter` controller services to split the data into individual flowfiles, then used `LookupRecord` with `ScriptedLookupService` and wrote a custom Groovy implementation which performed position lookups. Finally, I output the enriched flowfiles to a `ConvertRecord` processor which wrote them out in JSON.

          Looks very useful and I think this will make a lot of people's flows more powerful. Thanks Matt.

          +1, merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1828 Built with `contrib-check` and all tests pass. With Matt's help, I created a schema registry with a defined schema, generated flowfiles with CSV formatted data (a hockey roster), and used `SplitRecord` with the `CSVReader` and `CSVRecordSetWriter` controller services to split the data into individual flowfiles, then used `LookupRecord` with `ScriptedLookupService` and wrote a custom Groovy implementation which performed position lookups. Finally, I output the enriched flowfiles to a `ConvertRecord` processor which wrote them out in JSON. Looks very useful and I think this will make a lot of people's flows more powerful. Thanks Matt. +1, merging.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9294a2613913f28789a1989744c5c79108768eeb in nifi's branch refs/heads/master from Matt Burgess
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9294a26 ]

          NIFI-3938: Added ScriptedLookupService, some refactor for reusable scripting classes

          This closes #1828.

          Signed-off-by: Andy LoPresto <alopresto@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9294a2613913f28789a1989744c5c79108768eeb in nifi's branch refs/heads/master from Matt Burgess [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9294a26 ] NIFI-3938 : Added ScriptedLookupService, some refactor for reusable scripting classes This closes #1828. Signed-off-by: Andy LoPresto <alopresto@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1828

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1828
          Hide
          pvillard Pierre Villard added a comment -

          Hey Andy LoPresto, would you mind attaching a template to this JIRA with what you did for the review? That would be great!

          Show
          pvillard Pierre Villard added a comment - Hey Andy LoPresto , would you mind attaching a template to this JIRA with what you did for the review? That would be great!
          Hide
          alopresto Andy LoPresto added a comment -

          Pierre Villard I posted the flow here and the Groovy script I wrote here. The SplitRecord processor is superfluous, as I was just exploring the *Record processors.

          Enjoy.

          Show
          alopresto Andy LoPresto added a comment - Pierre Villard I posted the flow here and the Groovy script I wrote here . The SplitRecord processor is superfluous, as I was just exploring the *Record processors. Enjoy.

            People

            • Assignee:
              mattyb149 Matt Burgess
              Reporter:
              mattyb149 Matt Burgess
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development