Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3903

Basic Unit Test Coverage for AWS Processors

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      Many of the AWS processors rely heavily on integration tests for coverage of major features. While there is no substitute for running the code against a live AWS environment, the live environment requirement means that integration tests are run infrequently. Regular unit tests should be included:

      • Provide coverage of basic features without integration tests
      • Demonstrate at least one mocking pattern for testing AWS request/response
      • Remove excuses for not providing unit tests with new features
      • Clarify integration tests vs. unit tests

      Processors that need help include:

      • InvokeLambda
      • DeleteS3Object, FetchS3Object, PutS3Object, ListS3
      • PutSNS
      • DeleteSQS, GetSQS, PutSQS

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user jvwing opened a pull request:

          https://github.com/apache/nifi/pull/1814

          NIFI-3903 Unit Tests for AWS Processors

          • Added non-integration unit tests for Lambda, S3, SNS, and SQS processors
          • Moved non-integration tests out of integration test files
          • Moved SQS integration tests to IT* files for clarification

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [X] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [X] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [X] Have you written or updated unit tests to verify your changes?
          • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
          • [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
          • [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
          • [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
              1. For documentation related changes:
          • [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/jvwing/nifi NIFI-3903-aws-unit-tests-2

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1814.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1814


          commit caee7b11c96e14287db97d9e6d0b059504c2de4e
          Author: James Wing <jvwing@gmail.com>
          Date: 2017-05-11T21:48:57Z

          NIFI-3903 Unit Tests for AWS Processors

          • Added non-integration unit tests for Lambda, S3, SNS, and SQS processors
          • Moved non-integration tests out of integration test files
          • Moved SQS integration tests to IT* files for clarification

          Show
          githubbot ASF GitHub Bot added a comment - GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1814 NIFI-3903 Unit Tests for AWS Processors Added non-integration unit tests for Lambda, S3, SNS, and SQS processors Moved non-integration tests out of integration test files Moved SQS integration tests to IT* files for clarification Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [X] Has your PR been rebased against the latest commit within the target branch (typically master)? [X] Is your initial contribution a single, squashed commit? For code changes: [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [X] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? For documentation related changes: [ ] Have you ensured that format looks appropriate for the output in which it is rendered? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jvwing/nifi NIFI-3903 -aws-unit-tests-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1814.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1814 commit caee7b11c96e14287db97d9e6d0b059504c2de4e Author: James Wing <jvwing@gmail.com> Date: 2017-05-11T21:48:57Z NIFI-3903 Unit Tests for AWS Processors Added non-integration unit tests for Lambda, S3, SNS, and SQS processors Moved non-integration tests out of integration test files Moved SQS integration tests to IT* files for clarification
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pvillard31 commented on the issue:

          https://github.com/apache/nifi/pull/1814

          OK... nice PR! Checked out the code, all LGTM, checked code coverage with added unit tests, full build with contrib check is OK. Merging to master, thanks for the amazing work @jvwing!

          Show
          githubbot ASF GitHub Bot added a comment - Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1814 OK... nice PR! Checked out the code, all LGTM, checked code coverage with added unit tests, full build with contrib check is OK. Merging to master, thanks for the amazing work @jvwing!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9238fdb493fe56704958dc8fc465d109939a994e in nifi's branch refs/heads/master from James Wing
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9238fdb ]

          NIFI-3903 Unit Tests for AWS Processors

          • Added non-integration unit tests for Lambda, S3, SNS, and SQS processors
          • Moved non-integration tests out of integration test files
          • Moved SQS integration tests to IT* files for clarification

          Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

          This closes #1814.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9238fdb493fe56704958dc8fc465d109939a994e in nifi's branch refs/heads/master from James Wing [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=9238fdb ] NIFI-3903 Unit Tests for AWS Processors Added non-integration unit tests for Lambda, S3, SNS, and SQS processors Moved non-integration tests out of integration test files Moved SQS integration tests to IT* files for clarification Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #1814.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1814

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1814
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jvwing commented on the issue:

          https://github.com/apache/nifi/pull/1814

          Thanks again, @pvillard31

          Show
          githubbot ASF GitHub Bot added a comment - Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1814 Thanks again, @pvillard31

            People

            • Assignee:
              jameswing James Wing
              Reporter:
              jameswing James Wing
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development