Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Add support for custom headers to be sent with the request, specified through dynamic properties.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tequalsme opened a pull request:

          https://github.com/apache/nifi/pull/1776

          NIFI-3858 PostHTTP support for custom headers via dynamic properties

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tequalsme/nifi nifi-3858

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1776.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1776


          commit 3a688296333ba006d820ac163a5c5d213cff397e
          Author: Tim Reardon <tequalsme@gmail.com>
          Date: 2017-05-09T18:20:14Z

          NIFI-3858 PostHTTP support for custom headers via dynamic properties


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tequalsme opened a pull request: https://github.com/apache/nifi/pull/1776 NIFI-3858 PostHTTP support for custom headers via dynamic properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/tequalsme/nifi nifi-3858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1776 commit 3a688296333ba006d820ac163a5c5d213cff397e Author: Tim Reardon <tequalsme@gmail.com> Date: 2017-05-09T18:20:14Z NIFI-3858 PostHTTP support for custom headers via dynamic properties
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jvwing commented on the issue:

          https://github.com/apache/nifi/pull/1776

          Reviewing...

          Show
          githubbot ASF GitHub Bot added a comment - Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1776 Reviewing...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jvwing commented on the issue:

          https://github.com/apache/nifi/pull/1776

          Are you aware that PostHTTP already supports custom headers via the "Attributes to Send as HTTP Headers (Regex)" property? Without the existing feature, I would find the dynamic attribute method intuitive enough. But I'm concerned about having two custom header methods, especially when they potentially conflict.

          Show
          githubbot ASF GitHub Bot added a comment - Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1776 Are you aware that PostHTTP already supports custom headers via the "Attributes to Send as HTTP Headers (Regex)" property? Without the existing feature, I would find the dynamic attribute method intuitive enough. But I'm concerned about having two custom header methods, especially when they potentially conflict.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tequalsme commented on the issue:

          https://github.com/apache/nifi/pull/1776

          @jvwing Thanks for reviewing. This was a feature that my team added to our Nifi fork some time ago. I think it was done because the existing functionality does not support regular expressions, and was found to be more cumbersome to use than simply setting dynamic attributes. However I agree with your point that it doesn't make sense to have two custom header methods, so I will close.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tequalsme commented on the issue: https://github.com/apache/nifi/pull/1776 @jvwing Thanks for reviewing. This was a feature that my team added to our Nifi fork some time ago. I think it was done because the existing functionality does not support regular expressions, and was found to be more cumbersome to use than simply setting dynamic attributes. However I agree with your point that it doesn't make sense to have two custom header methods, so I will close.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tequalsme closed the pull request at:

          https://github.com/apache/nifi/pull/1776

          Show
          githubbot ASF GitHub Bot added a comment - Github user tequalsme closed the pull request at: https://github.com/apache/nifi/pull/1776

            People

            • Assignee:
              Unassigned
              Reporter:
              treardon Tim Reardon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development