Uploaded image for project: 'Apache NiFi'
  1. Apache NiFi
  2. NIFI-3816

Add JSON mime.type attribute for S2S Provenance and Bulletins reporting tasks

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      I noticed that only the S2S Status reporting task is setting application/json for mime.type attribute in generated flow files. It should be added to other S2S reporting tasks as it's easier to display the flow file content in the UI when the correct mime.type is set.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user pvillard31 opened a pull request:

          https://github.com/apache/nifi/pull/1758

          NIFI-3816 - Added correct mime.type to S2S bulletin and provenance re…

          …porting tasks

          Thank you for submitting a contribution to Apache NiFi.

          In order to streamline the review of the contribution we ask you
          to ensure the following steps have been taken:

              1. For all changes:
          • [X] Is there a JIRA ticket associated with this PR? Is it referenced
            in the commit message?
          • [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
          • [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
          • [X] Is your initial contribution a single, squashed commit?
              1. For code changes:
          • [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
          • [ ] Have you written or updated unit tests to verify your changes?
              1. Note:
                Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/pvillard31/nifi NIFI-3816

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/nifi/pull/1758.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1758


          commit f9e0150c48e957309d44f0fd2b87ddaedf088e1f
          Author: Pierre Villard <pierre.villard.fr@gmail.com>
          Date: 2017-05-05T16:09:04Z

          NIFI-3816 - Added correct mime.type to S2S bulletin and provenance reporting tasks


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1758 NIFI-3816 - Added correct mime.type to S2S bulletin and provenance re… …porting tasks Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [X] Has your PR been rebased against the latest commit within the target branch (typically master)? [X] Is your initial contribution a single, squashed commit? For code changes: [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? [ ] Have you written or updated unit tests to verify your changes? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-3816 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1758.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1758 commit f9e0150c48e957309d44f0fd2b87ddaedf088e1f Author: Pierre Villard <pierre.villard.fr@gmail.com> Date: 2017-05-05T16:09:04Z NIFI-3816 - Added correct mime.type to S2S bulletin and provenance reporting tasks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ijokarumawak commented on the issue:

          https://github.com/apache/nifi/pull/1758

          Confirmed this change adds correct mime.type and transferred bulletin messages can be seen with NiFi content viewer as formatted JSON. LGTM +1. Thanks @pvillard31 !

          Show
          githubbot ASF GitHub Bot added a comment - Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1758 Confirmed this change adds correct mime.type and transferred bulletin messages can be seen with NiFi content viewer as formatted JSON. LGTM +1. Thanks @pvillard31 !
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bb96b0f46412008ade2b5abe2d4ee9970af576fd in nifi's branch refs/heads/master from Pierre Villard
          [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=bb96b0f ]

          NIFI-3816 - Added correct mime.type to S2S bulletin and provenance reporting tasks

          This closes #1758.

          Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>

          Show
          jira-bot ASF subversion and git services added a comment - Commit bb96b0f46412008ade2b5abe2d4ee9970af576fd in nifi's branch refs/heads/master from Pierre Villard [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=bb96b0f ] NIFI-3816 - Added correct mime.type to S2S bulletin and provenance reporting tasks This closes #1758. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/nifi/pull/1758

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1758

            People

            • Assignee:
              pvillard Pierre Villard
              Reporter:
              pvillard Pierre Villard
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development